Page MenuHomeSoftware Heritage

cli: Increase open file descriptor limit to support 256 open LevelDBs
ClosedPublic

Authored by vlorentz on Nov 4 2022, 10:19 AM.

Diff Detail

Repository
rDDATASET Datasets
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D8810 (id=31743)

Rebasing onto 735397ac85...

Current branch diff-target is up to date.
Changes applied before test
commit cd9408c65fffbb57b528d6f1c7907ea99aa3ba37
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Nov 4 10:18:56 2022 +0100

    cli: Increase open file descriptor limit to support 256 open LevelDBs

See https://jenkins.softwareheritage.org/job/DDATASET/job/tests-on-diff/155/ for more details.

olasd added a subscriber: olasd.

Thanks; I have one comment inline that I think should be addressed!

swh/dataset/cli.py
149–153

The logging is inconsistent with the actual new value of the limit, which may end up surprising people

This revision is now accepted and ready to land.Nov 4 2022, 3:52 PM

Build is green

Patch application report for D8810 (id=31760)

Rebasing onto 735397ac85...

Current branch diff-target is up to date.
Changes applied before test
commit b2ae082661f39833e11479292641b233dadfe044
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Nov 4 10:18:56 2022 +0100

    cli: Increase open file descriptor limit to support 256 open LevelDBs

See https://jenkins.softwareheritage.org/job/DDATASET/job/tests-on-diff/156/ for more details.