Page MenuHomeSoftware Heritage

Dump all known and remote heads when debugging
ClosedPublic

Authored by olasd on Nov 3 2022, 4:29 PM.

Details

Summary

Helpful to get a sense of what the local snapshot looks like when doing
an incremental load.

Diff Detail

Repository
rDLDG Git loader
Branch
detached-head
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 32691
Build 51213: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 51212: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D8806 (id=31736)

Rebasing onto d6d5ce2b58...

Current branch diff-target is up to date.
Changes applied before test
commit 35ecf1843696b3676275920c86bce0c88ca75427
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Thu Nov 3 15:21:45 2022 +0100

    Dump all known and remote heads when debugging

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/233/ for more details.

olasd requested review of this revision.Nov 3 2022, 4:32 PM
This revision is now accepted and ready to land.Nov 4 2022, 9:15 AM
anlambert added a subscriber: anlambert.
anlambert added inline comments.
swh/loader/git/loader.py
82

Is this instruction really needed ?

swh/loader/git/loader.py
82

Well, it just avoids doing a for loop of useless debugging statements when debugging is not enabled. Not super critical, but doesn't hurt.