Differential D8693

replay: Use swh.model.from_disk.Directory.collect
ClosedPublic
Actions

Authored by anlambert on Oct 17 2022, 7:22 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLDSVNaaa82617befc: replay: Use swh.model.from_disk.Directory.collect

Summary

Instead of maintaining a set of modified paths for each replayed revision,
use the swh.model.from_disk.Directory.collect method which performs the same
task by returning added or modified contents and directories since the last
collect operation.

Diff Detail

Repository

rDLDSVN Subversion (SVN) loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Oct 17 2022, 7:22 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 17 2022, 7:22 PM

Build is green

Patch application report for D8693 (id=31396)

Rebasing onto 8e735c953b...

Current branch diff-target is up to date.

Changes applied before test

commit aaa82617befcdf42e42f3839734ff1d2109d5945
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Oct 17 19:21:52 2022 +0200

    replay: Use swh.model.from_disk.Directory.collect
    
    Instead of maintaining a set of modified paths for each replayed revision,
    use the swh.model.from_disk.Directory.collect method which performs the same
    task by returning added or modified contents and directories since the last
    collect operation.

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/336/ for more details.

Harbormaster completed remote builds in B32343: Diff 31396.Oct 17 2022, 7:25 PM

anlambert requested review of this revision.Oct 17 2022, 7:25 PM