maven: Make assertions more useful
ClosedPublic
Actions

Authored by vlorentz on Oct 13 2022, 5:41 PM.

Details

Reviewers

anlambert
ardumont

Group Reviewers

Reviewers

Commits

rDLS3dbe77156cab: maven: Make assertions more useful

Summary

By using set equality, pytest can diff both operands; whereas equality
comparisons failures are harder to read.

Diff Detail

Repository

rDLS Listers

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Oct 13 2022, 5:41 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 13 2022, 5:41 PM

Build is green

Patch application report for D8679 (id=31347)

Rebasing onto a681f2f405...

Current branch diff-target is up to date.

Changes applied before test

commit 3dbe77156cab18ad532dfc363b1a5a7a42f26b4e
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Oct 13 17:41:11 2022 +0200

    maven: Make assertions more useful
    
    By using set equality, pytest can diff both operands; whereas equality
    comparisons failures are harder to read.

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/798/ for more details.

Harbormaster completed remote builds in B32295: Diff 31347.Oct 13 2022, 5:46 PM

vlorentz requested review of this revision.Oct 13 2022, 5:46 PM

anlambert accepted this revision.Oct 13 2022, 5:52 PM

This revision is now accepted and ready to land.Oct 13 2022, 5:52 PM

vlorentz added a child revision: D8680: maven: Use requests_mock_datadir to simplify mocking..Oct 13 2022, 5:58 PM

ardumont accepted this revision.Oct 13 2022, 8:07 PM

Closed by commit rDLS3dbe77156cab: maven: Make assertions more useful (authored by vlorentz). · Explain WhyOct 17 2022, 8:48 AM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDLS3dbe77156cab: maven: Make assertions more useful.