Page MenuHomeSoftware Heritage
Differential D8610

nixguix: Refactor by cleaning up unneeded code
ClosedPublic
Actions

Authored by ardumont on Oct 4 2022, 2:40 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Maniphest Tasks
T3781: Replace the Nixguix loader with a lister
Commits
rDLSd92474bbda68: nixguix: Refactor by cleaning up unneeded code
Summary

Related to T3781

Diff Detail

Repository
rDLS Listers
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 32072
Build 50214: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 50213: arc lint + arc unit

Event Timeline

ardumont created this revision.Oct 4 2022, 2:40 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptOct 4 2022, 2:40 PM
vlorentz published this revision for review.Oct 4 2022, 2:41 PM
vlorentz accepted this revision.
This revision is now accepted and ready to land.Oct 4 2022, 2:41 PM
swh-public-ci added a comment.Oct 4 2022, 2:48 PM

Build is green

Patch application report for D8610 (id=31102)

Rebasing onto 06b11dd5f6...

Current branch diff-target is up to date.
Changes applied before test
commit e2420422af22b6d95b3424cdb544f8886069f75c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Oct 4 14:39:53 2022 +0200

    nixguix: Refactor by cleaning up unneeded code
    
    Related to T3781

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/742/ for more details.

Harbormaster completed remote builds in B32072: Diff 31102.Oct 4 2022, 2:48 PM
ardumont updated this revision to Diff 31103.Oct 4 2022, 2:49 PM

Drop no forgotten commit that could have been dropped early on.

This revision was landed with ongoing or failed builds.Oct 4 2022, 2:49 PM
Closed by commit rDLSd92474bbda68: nixguix: Refactor by cleaning up unneeded code (authored by ardumont). · Explain Why
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDLSd92474bbda68: nixguix: Refactor by cleaning up unneeded code.
swh-public-ci added a comment.Oct 4 2022, 2:54 PM

Build is green

Patch application report for D8610 (id=31103)

Rebasing onto d92474bbda...

First, rewinding head to replay your work on top of it...
Fast-forwarded diff-target to base-revision-743-D8610.
Changes applied before test



See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/743/ for more details.
Harbormaster completed remote builds in B32073: Diff 31103.Oct 4 2022, 2:54 PM
Revision Contents
Changeset List
PathSizeCoverage (All)Coverage (Touched)
swh/
lister/
nixguix/
34 lines99%
Loading...
Diff 31102
View Options
swh/lister/nixguix/lister.py
Loading...
About · Developer information · Legal