Page MenuHomeSoftware Heritage
Differential D8495

package/utils: Add debug log and throttling retry to api_info
ClosedPublic
Actions

Authored by anlambert on Sep 16 2022, 1:18 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDLDBASEe1f2135f241c: package/utils: rename api_info function to get_url_body
rDLDBASEbcbb554e625f: package/utils: Add debug log and throttling retry to api_info
Summary

This function is used in multiple package loaders so add a throttling
retry policy and debug log about fetched URL.

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Sep 16 2022, 1:18 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptSep 16 2022, 1:18 PM
swh-public-ci added a comment.Sep 16 2022, 1:22 PM

Build is green

Patch application report for D8495 (id=30589)

Rebasing onto 134087342b...

Current branch diff-target is up to date.
Changes applied before test
commit 8ca8c2cf31066ffa07722cb44c72c978af04a0ed
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Sep 16 13:16:43 2022 +0200

    package/utils: Add debug log and throttling retry to api_info
    
    This function is used in multiple package loaders so add a throttling
    retry policy and debug log about fetched URL.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/870/ for more details.

Harbormaster completed remote builds in B31581: Diff 30589.Sep 16 2022, 1:22 PM
anlambert requested review of this revision.Sep 16 2022, 1:22 PM
vlorentz added a subscriber: vlorentz.Sep 18 2022, 2:11 PM

api_info sounds like it returns information about an API. Could you rename it to get_url_body?

anlambert added a comment.Sep 19 2022, 10:32 AM
In D8495#220442, @vlorentz wrote:

api_info sounds like it returns information about an API. Could you rename it to get_url_body?

Sure, will add a new commit to the diff.

anlambert updated this revision to Diff 30612.Sep 19 2022, 11:38 AM

Rebase and rename api_info to get_url_body

swh-public-ci added a comment.Sep 19 2022, 11:41 AM

Build is green

Patch application report for D8495 (id=30612)

Rebasing onto 0c599bdc81...

Current branch diff-target is up to date.
Changes applied before test
commit fbcfcbebd01b7d501f6ff7463fd63e4e1293bb32
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Sep 19 11:33:16 2022 +0200

    package/utils: rename api_info function to get_url_body
    
    This naming is more explicit about what this function is doing.

commit e171b6b198807dd0f17b1b92a5de1b08605ca43f
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Sep 16 13:16:43 2022 +0200

    package/utils: Add debug log and throttling retry to api_info
    
    This function is used in multiple package loaders so add a throttling
    retry policy and debug log about fetched URL.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/874/ for more details.

Harbormaster completed remote builds in B31597: Diff 30612.Sep 19 2022, 11:41 AM
anlambert updated this revision to Diff 30646.Sep 20 2022, 2:58 PM

Rebase

swh-public-ci added a comment.Sep 20 2022, 3:01 PM

Build is green

Patch application report for D8495 (id=30646)

Rebasing onto d471cca9f2...

Current branch diff-target is up to date.
Changes applied before test
commit fa5ed9ecb32cca21a871dbc87a500b509ea9588d
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Sep 19 11:33:16 2022 +0200

    package/utils: rename api_info function to get_url_body
    
    This naming is more explicit about what this function is doing.

commit bcbb554e625f0dfd382d0bad5c1afc77856a5b38
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Sep 16 13:16:43 2022 +0200

    package/utils: Add debug log and throttling retry to api_info
    
    This function is used in multiple package loaders so add a throttling
    retry policy and debug log about fetched URL.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/883/ for more details.

Harbormaster completed remote builds in B31625: Diff 30646.Sep 20 2022, 3:01 PM
vlorentz accepted this revision.Sep 21 2022, 2:25 PM
This revision is now accepted and ready to land.Sep 21 2022, 2:25 PM
anlambert updated this revision to Diff 30674.Sep 21 2022, 3:45 PM

Update doctring

swh-public-ci added a comment.Sep 21 2022, 3:49 PM

Build is green

Patch application report for D8495 (id=30674)

Rebasing onto d471cca9f2...

Current branch diff-target is up to date.
Changes applied before test
commit e1f2135f241ceb0794c4ec3ddabbc7da5d64ac5e
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Sep 19 11:33:16 2022 +0200

    package/utils: rename api_info function to get_url_body
    
    This naming is more explicit about what this function is doing.

commit bcbb554e625f0dfd382d0bad5c1afc77856a5b38
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Sep 16 13:16:43 2022 +0200

    package/utils: Add debug log and throttling retry to api_info
    
    This function is used in multiple package loaders so add a throttling
    retry policy and debug log about fetched URL.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/884/ for more details.

Harbormaster completed remote builds in B31652: Diff 30674.Sep 21 2022, 3:49 PM
Closed by commit rDLDBASEbcbb554e625f: package/utils: Add debug log and throttling retry to api_info (authored by anlambert). · Explain WhySep 21 2022, 3:49 PM
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDLDBASEbcbb554e625f: package/utils: Add debug log and throttling retry to api_info.
anlambert added a commit: rDLDBASEe1f2135f241c: package/utils: rename api_info function to get_url_body.

Revision Contents
Changeset List

PathSize
swh/
loader/
package/
tests/
43 lines
48 lines

Diff 30675

View Options

swh/loader/package/tests/test_utils.py

Loading...
View Options

swh/loader/package/utils.py

Loading...
About · Developer information · Legal