Page MenuHomeSoftware Heritage

package/utils: Add debug log and throttling retry to api_info
ClosedPublic

Authored by anlambert on Fri, Sep 16, 1:18 PM.

Details

Summary

This function is used in multiple package loaders so add a throttling
retry policy and debug log about fetched URL.

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D8495 (id=30589)

Rebasing onto 134087342b...

Current branch diff-target is up to date.
Changes applied before test
commit 8ca8c2cf31066ffa07722cb44c72c978af04a0ed
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Sep 16 13:16:43 2022 +0200

    package/utils: Add debug log and throttling retry to api_info
    
    This function is used in multiple package loaders so add a throttling
    retry policy and debug log about fetched URL.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/870/ for more details.

api_info sounds like it returns information about an API. Could you rename it to get_url_body?

api_info sounds like it returns information about an API. Could you rename it to get_url_body?

Sure, will add a new commit to the diff.

Rebase and rename api_info to get_url_body

Build is green

Patch application report for D8495 (id=30612)

Rebasing onto 0c599bdc81...

Current branch diff-target is up to date.
Changes applied before test
commit fbcfcbebd01b7d501f6ff7463fd63e4e1293bb32
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Sep 19 11:33:16 2022 +0200

    package/utils: rename api_info function to get_url_body
    
    This naming is more explicit about what this function is doing.

commit e171b6b198807dd0f17b1b92a5de1b08605ca43f
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Sep 16 13:16:43 2022 +0200

    package/utils: Add debug log and throttling retry to api_info
    
    This function is used in multiple package loaders so add a throttling
    retry policy and debug log about fetched URL.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/874/ for more details.

Build is green

Patch application report for D8495 (id=30646)

Rebasing onto d471cca9f2...

Current branch diff-target is up to date.
Changes applied before test
commit fa5ed9ecb32cca21a871dbc87a500b509ea9588d
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Sep 19 11:33:16 2022 +0200

    package/utils: rename api_info function to get_url_body
    
    This naming is more explicit about what this function is doing.

commit bcbb554e625f0dfd382d0bad5c1afc77856a5b38
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Sep 16 13:16:43 2022 +0200

    package/utils: Add debug log and throttling retry to api_info
    
    This function is used in multiple package loaders so add a throttling
    retry policy and debug log about fetched URL.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/883/ for more details.

This revision is now accepted and ready to land.Wed, Sep 21, 2:25 PM

Build is green

Patch application report for D8495 (id=30674)

Rebasing onto d471cca9f2...

Current branch diff-target is up to date.
Changes applied before test
commit e1f2135f241ceb0794c4ec3ddabbc7da5d64ac5e
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Sep 19 11:33:16 2022 +0200

    package/utils: rename api_info function to get_url_body
    
    This naming is more explicit about what this function is doing.

commit bcbb554e625f0dfd382d0bad5c1afc77856a5b38
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Sep 16 13:16:43 2022 +0200

    package/utils: Add debug log and throttling retry to api_info
    
    This function is used in multiple package loaders so add a throttling
    retry policy and debug log about fetched URL.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/884/ for more details.