Page MenuHomeSoftware Heritage
Differential D8439

Rename thanos-gateway service to thanos-store to match upstream
ClosedPublic
Actions

Authored by olasd on Sep 9 2022, 6:30 PM.

Details

Reviewers
ardumont
Group Reviewers
System administrators
Commits
rSPSITE6246518e45fd: Rename thanos-gateway service to thanos-store to match upstream
Summary

I get confused every time I try to explain things, this may help

Diff Detail

Repository
rSPSITE puppet-swh-site
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Sep 9 2022, 6:30 PM
Herald added a reviewer: System administrators. · View Herald TranscriptSep 9 2022, 6:30 PM
olasd requested review of this revision.Sep 9 2022, 6:30 PM
Harbormaster completed remote builds in B31444: Diff 30428.Sep 9 2022, 6:30 PM
olasd added a child revision: D8440: Split thanos objstore configuration management to separate class.Sep 9 2022, 6:31 PM
ardumont accepted this revision.Sep 12 2022, 9:34 AM
ardumont added a subscriber: ardumont.

Thanks.

I agree it was confusing but i merely used upstream's documentation term at the time.
Hopefully, that will help.

This revision is now accepted and ready to land.Sep 12 2022, 9:34 AM
ardumont added a comment.Sep 12 2022, 9:36 AM

yes, sounds definitely better (i've read it another round ;)

Closed by commit rSPSITE6246518e45fd: Rename thanos-gateway service to thanos-store to match upstream (authored by olasd). · Explain WhySep 12 2022, 12:51 PM
This revision was automatically updated to reflect the committed changes.
olasd added a commit: rSPSITE6246518e45fd: Rename thanos-gateway service to thanos-store to match upstream.

Revision Contents
Changeset List

PathSize
data/
common/
17 lines
site-modules/
profile/
manifests/
thanos/
2 lines
store.pp
gateway.pp
56 lines
templates/
thanos/
store-parameters.conf.erb
gateway-parameters.conf.erb
3 lines
store@.service.erb
gateway@.service.erb
6 lines
role/
manifests/
2 lines

Diff 30443

View Options

data/common/common.yaml

Loading...
View Options

site-modules/profile/manifests/thanos/base.pp

Loading...
View Options

site-modules/profile/manifests/thanos/gateway.pp

Loading...
View Options

site-modules/profile/manifests/thanos/store.pp

Loading...
View Options

site-modules/profile/templates/thanos/gateway-parameters.conf.erb

Loading...
View Options

site-modules/profile/templates/thanos/gateway@.service.erb

Loading...
View Options

site-modules/profile/templates/thanos/store-parameters.conf.erb

Loading...
View Options

site-modules/profile/templates/thanos/store@.service.erb

Loading...
View Options

site-modules/role/manifests/swh_thanos.pp

Loading...
About · Developer information · Legal