It enables to search sentry events related to a particular loaded origin
URL or for a given visit type from the sentry Web UI.
See Searchable Properties and Customize Tags in Sentry documentation.
Details
Details
- Reviewers
vlorentz - Group Reviewers
Reviewers - Commits
- rDLDBASE4a2fe2f861be: loader: Add origin URL and visit type as sentry tags
Diff Detail
Diff Detail
- Repository
- rDLDBASE Generic VCS/Package Loader
- Branch
- add-useful-sentry-tags
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 31439 Build 49179: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 49178: arc lint + arc unit
| Time | Test | |
|---|---|---|
| 46 ms | Jenkins > .tox.py3.lib.python3.7.site-packages.swh.loader.core.tests.test_loader::test_loader_sentry_tags_on_error[DummyDVCSLoaderWithError] file /var/lib/jenkins/workspace/DLDBASE/tests-on-diff/.tox/py3/lib/python3.7/site-packages/swh/loader/core/tests/test_loader.py, line 499
@pytest.mark.parametrize("loader_cls", [DummyLoaderWithError, DummyDVCSLoaderWithError])
def test_loader_sentry_tags_on_error(swh_storage, sentry_events, loader_cls):
| |
| 247 ms | Jenkins > .tox.py3.lib.python3.7.site-packages.swh.loader.core.tests.test_loader::test_loader_sentry_tags_on_error[DummyLoaderWithError] file /var/lib/jenkins/workspace/DLDBASE/tests-on-diff/.tox/py3/lib/python3.7/site-packages/swh/loader/core/tests/test_loader.py, line 499
@pytest.mark.parametrize("loader_cls", [DummyLoaderWithError, DummyDVCSLoaderWithError])
def test_loader_sentry_tags_on_error(swh_storage, sentry_events, loader_cls):
| |
| 455 ms | Jenkins > .tox.py3.lib.python3.7.site-packages.swh.loader.package.tests.test_loader::test_loader_sentry_tags_on_error file /var/lib/jenkins/workspace/DLDBASE/tests-on-diff/.tox/py3/lib/python3.7/site-packages/swh/loader/package/tests/test_loader.py, line 532
def test_loader_sentry_tags_on_error(swh_storage, sentry_events):
E fixture 'sentry_events' not found
| |
| 1 ms | Jenkins > .tox.py3.lib.python3.7.site-packages.swh.loader.core.tests.test_converters::test_content_for_storage_data | |
| 4 ms | Jenkins > .tox.py3.lib.python3.7.site-packages.swh.loader.core.tests.test_converters::test_content_for_storage_path | |
| View Full Test Results (3 Failed · 238 Passed) |
Event Timeline
| swh/loader/core/tests/conftest.py | ||
|---|---|---|
| 1 ↗ | (On Diff #30391) | Copied and pasted from swh-indexer conftest file. It could be moved to a pytest plugin in swh-core to avoid code duplication. |
Comment Actions
Build is green
Patch application report for D8430 (id=30391)
Rebasing onto 6cdf6d3004...
Current branch diff-target is up to date.
Changes applied before test
commit b41a92d72654af6d0c83095c0dbce7895bbca087
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date: Thu Sep 8 17:21:01 2022 +0200
loader: Add origin URL and visit type as sentry tags
It enables to search sentry events related to a particular loaded origin
URL or for a given visit type from the sentry Web UI.See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/864/ for more details.
Comment Actions
Hmm, I was about to say:
I think it would make more sense to use breadcrumbs here.
I used tags in swh-indexer because it handles origins and objects in batch, so "current origin/object" keeps changing back and forth.
But actually, breadcrumbs are flooded with request logs, so I guess tags are good to make this visible.
Comment Actions
I also think that using tags is the right choice here.
We will be able to quickly find related issues and events associated to an origin URL using the sentry search form as you can currently
do with swh-indexer ones.
I just noticed that base class for package loaders override the load method so I should also set sentry tags here, will update.
Comment Actions
Update:
- Move sentry_sdk.set_tag calls in BaseLoader constructor in order for package loaders to also benefit from them in sentry reports
- Add test for package loader checking tags are correctly sent to sentry
Comment Actions
Build has FAILED
Patch application report for D8430 (id=30422)
Rebasing onto 6cdf6d3004...
Current branch diff-target is up to date.
Changes applied before test
commit 010b59e10b541a1d6fe039c0cfb98da0c8eb3410
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date: Thu Sep 8 17:21:01 2022 +0200
loader: Add origin URL and visit type as sentry tags
It enables to search sentry events related to a particular loaded origin
URL or for a given visit type from the sentry Web UI.Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/865/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/865/console
Comment Actions
Build has FAILED
Patch application report for D8430 (id=30423)
Rebasing onto 6cdf6d3004...
Current branch diff-target is up to date.
Changes applied before test
commit 4a2fe2f861be3b4e2af2cf22fcc20d105a42fc86
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date: Thu Sep 8 17:21:01 2022 +0200
loader: Add origin URL and visit type as sentry tags
It enables to search sentry events related to a particular loaded origin
URL or for a given visit type from the sentry Web UI.Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/866/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/866/console
Comment Actions
Build is green
Patch application report for D8430 (id=30423)
Rebasing onto 6cdf6d3004...
Current branch diff-target is up to date.
Changes applied before test
commit 4a2fe2f861be3b4e2af2cf22fcc20d105a42fc86
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date: Thu Sep 8 17:21:01 2022 +0200
loader: Add origin URL and visit type as sentry tags
It enables to search sentry events related to a particular loaded origin
URL or for a given visit type from the sentry Web UI.See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/867/ for more details.