Differential D8346

Fix a couple of mypy issues
ClosedPublic
Actions

Authored by douardda on Aug 30 2022, 2:01 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDPROV4a241adbab75: Fix a couple of mypy issues

Summary

On my setup (bullseye, python39), without these, I get the following errors:

swh/provenance/postgresql/archive.py:115: error: Incompatible return value type (got "List[Tuple[Any, ...]]", expected "List[Tuple[bytes, bytes]]")
swh/provenance/postgresql/provenance.py:93: error: Value of type "Optional[RealDictRow]" is not indexable

Diff Detail

Repository

rDPROV Provenance database

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Aug 30 2022, 2:01 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 30 2022, 2:01 PM

Build is green

Patch application report for D8346 (id=30133)

Rebasing onto 8f476d494b...

Current branch diff-target is up to date.

Changes applied before test

commit 4a241adbab75d822ab73b7907c91b973058a7e4e
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Aug 30 12:35:15 2022 +0200

    Fix a couple of mypy issues

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/651/ for more details.

Harbormaster completed remote builds in B31176: Diff 30133.Aug 30 2022, 2:09 PM

douardda requested review of this revision.Aug 30 2022, 2:09 PM

vlorentz accepted this revision.Aug 31 2022, 10:30 AM

This revision is now accepted and ready to land.Aug 31 2022, 10:30 AM

Closed by commit rDPROV4a241adbab75: Fix a couple of mypy issues (authored by douardda). · Explain WhyAug 31 2022, 3:11 PM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDPROV4a241adbab75: Fix a couple of mypy issues.