Page MenuHomeSoftware Heritage

arch: Un-nest long method
ClosedPublic

Authored by vlorentz on Aug 24 2022, 5:24 PM.

Details

Diff Detail

Repository
rDLS Listers
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D8308 (id=29991)

Could not rebase; Attempt merge onto 4b511b4181...

Updating 4b511b4..3190416
Fast-forward
 swh/lister/arch/lister.py                 | 203 +++++++++++++++---------------
 swh/lister/arch/tests/test_lister.py      |  22 ++--
 swh/lister/aur/tests/test_lister.py       |  18 +--
 swh/lister/bitbucket/tests/test_lister.py |  12 +-
 swh/lister/crates/tests/test_lister.py    |  60 ++++-----
 swh/lister/gitea/tests/test_lister.py     |   9 +-
 swh/lister/gogs/tests/test_lister.py      |   9 +-
 swh/lister/pypi/tests/test_lister.py      |   9 +-
 swh/lister/tuleap/tests/test_lister.py    |   8 +-
 9 files changed, 155 insertions(+), 195 deletions(-)
Changes applied before test
commit 319041612cd44fc79b2cbe881c1ca37e3f058d48
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Aug 24 17:23:45 2022 +0200

    arch: Un-nest long method

commit b7ec6cb120b4c2a5f2fb3153794a4c0f4fb97135
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Aug 24 17:21:24 2022 +0200

    tests: Simplify origin comparison and improve pytest diff on failure
    
    By using a single equality instead of checking len() then zip()
    to check one by one, pytest can find the common/missing elements
    and print them nicely when the two lists are unequal.

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/612/ for more details.

ardumont added a subscriber: ardumont.
ardumont added inline comments.
swh/lister/arch/lister.py
332
This revision is now accepted and ready to land.Aug 24 2022, 5:44 PM

Build is green

Patch application report for D8308 (id=30001)

Could not rebase; Attempt merge onto 4b511b4181...

Updating 4b511b4..766fbbc
Fast-forward
 swh/lister/arch/lister.py                 | 205 +++++++++++++++---------------
 swh/lister/arch/tests/test_lister.py      |  22 ++--
 swh/lister/aur/tests/test_lister.py       |  18 +--
 swh/lister/bitbucket/tests/test_lister.py |  12 +-
 swh/lister/crates/tests/test_lister.py    |  60 +++++----
 swh/lister/gitea/tests/test_lister.py     |   9 +-
 swh/lister/gogs/tests/test_lister.py      |   9 +-
 swh/lister/pypi/tests/test_lister.py      |   9 +-
 swh/lister/tuleap/tests/test_lister.py    |   8 +-
 9 files changed, 157 insertions(+), 195 deletions(-)
Changes applied before test
commit 766fbbcc918218f02a998aaff201cee0f9b88be3
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Aug 24 17:23:45 2022 +0200

    arch: Un-nest long method

commit b7ec6cb120b4c2a5f2fb3153794a4c0f4fb97135
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Aug 24 17:21:24 2022 +0200

    tests: Simplify origin comparison and improve pytest diff on failure
    
    By using a single equality instead of checking len() then zip()
    to check one by one, pytest can find the common/missing elements
    and print them nicely when the two lists are unequal.

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/616/ for more details.

This revision was automatically updated to reflect the committed changes.