Inject transitions dict into Django template instead and pass it to js.
Details
Details
- Reviewers
vlorentz - Group Reviewers
Reviewers - Commits
- rDWAPPSd72784ac6514: add_forge_now: Deduplicate request status transitions in js code
Diff Detail
Diff Detail
- Repository
- rDWAPPS Web applications
- Branch
- add-forge-now-no-state-transitions-duplication
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 30866 Build 48265: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 48264: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D8256 (id=29814)
Rebasing onto 568eb5d7ac...
Current branch diff-target is up to date.
Changes applied before test
commit 9027a2823d771010d91920555b11f42b9fb85d81
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date: Thu Aug 18 15:58:38 2022 +0200
add_forge_now: Do not duplicate request status transitions in js code
Inject transitions dict into Django template instead and pass it to js.See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1977/ for more details.
Comment Actions
s/Do not duplicate/Deduplicate/
| swh/web/add_forge_now/models.py | ||
|---|---|---|
| 66–71 | I'd rather have this in swh/web/admin/add_forge_now.py given that it's only needed for formatting, but ok | |
Comment Actions
Build is green
Patch application report for D8256 (id=29819)
Rebasing onto 568eb5d7ac...
Current branch diff-target is up to date.
Changes applied before test
commit d72784ac651499ce9875e1288395792efb758e25
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date: Thu Aug 18 15:58:38 2022 +0200
add_forge_now: Deduplicate request status transitions in js code
Inject transitions dict into Django template instead and pass it to js.See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1978/ for more details.