Page MenuHomeSoftware Heritage

bin/install: Temporarily pin pip to < 21.3
ClosedPublic

Authored by anlambert on Aug 17 2022, 5:33 PM.

Details

Summary

pip 21.3 added support to editable installs for projects that have a
pyproject.toml and use a build backend that supports PEP 660, but mypy
does not detect yet such editable installs and following errors are
reported when type checking swh modules:

Cannot find implementation or library stub for module named swh...

So temporarily pin pip until mypy properly supports PEP 660 editable
installs (see https://github.com/python/mypy/issues/12313).

Diff Detail

Repository
rDENV Development environment
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 30853
Build 48243: arc lint + arc unit

Event Timeline

vlorentz added inline comments.
bin/install
17

Shouldn't it be $PIP install "pip<21.3"?

This revision is now accepted and ready to land.Aug 18 2022, 10:02 AM
bin/install
17

Ah right, I am also wondering if pinning setuptools to < 64 (before PEP 660 support) is not the right way to go instead of pinning pip, need to check.

bin/install
17

Nope, pinning pip is the only way to keep mypy working with editable swh modules.

Use PIP variable to execute pip.