Differential D8192

Fix flakiness in test_directory_add_get_arbitrary
ClosedPublic
Actions

Authored by vlorentz on Aug 5 2022, 10:08 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDSTO4825f40a4fc1: Fix flakiness in test_directory_add_get_arbitrary

Summary

By ignoring other attributes when raw_manifest is not None;
just like we already do in test_revision_add_get_arbitrary
and test_release_add_get_arbitrary.

Diff Detail

Repository

rDSTO Storage manager

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 30632
Build 47895: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 47894: arc lint + arc unit

Event Timeline

vlorentz created this revision.Aug 5 2022, 10:08 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 5 2022, 10:08 AM

makes sense, thx.

This revision is now accepted and ready to land.Aug 5 2022, 10:12 AM

Build is green

Patch application report for D8192 (id=29566)

Rebasing onto fc89059579...

Current branch diff-target is up to date.

Changes applied before test

commit 4825f40a4fc12182ffa94a16f0f6fbf50db45038
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Aug 5 10:08:01 2022 +0200

    Fix flakiness in test_directory_add_get_arbitrary
    
    By ignoring other attributes when raw_manifest is not None;
    just like we already do in test_revision_add_get_arbitrary
    and test_release_add_get_arbitrary.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1642/ for more details.

Harbormaster completed remote builds in B30632: Diff 29566.Aug 5 2022, 10:24 AM

Closed by commit rDSTO4825f40a4fc1: Fix flakiness in test_directory_add_get_arbitrary (authored by vlorentz). · Explain WhyAug 5 2022, 10:27 AM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDSTO4825f40a4fc1: Fix flakiness in test_directory_add_get_arbitrary.