Page MenuHomeSoftware Heritage

Fix flakiness in test_directory_add_get_arbitrary
ClosedPublic

Authored by vlorentz on Fri, Aug 5, 10:08 AM.

Details

Summary

By ignoring other attributes when raw_manifest is not None;
just like we already do in test_revision_add_get_arbitrary
and test_release_add_get_arbitrary.

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont accepted this revision.
ardumont added a subscriber: ardumont.

makes sense, thx.

This revision is now accepted and ready to land.Fri, Aug 5, 10:12 AM

Build is green

Patch application report for D8192 (id=29566)

Rebasing onto fc89059579...

Current branch diff-target is up to date.
Changes applied before test
commit 4825f40a4fc12182ffa94a16f0f6fbf50db45038
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Aug 5 10:08:01 2022 +0200

    Fix flakiness in test_directory_add_get_arbitrary
    
    By ignoring other attributes when raw_manifest is not None;
    just like we already do in test_revision_add_get_arbitrary
    and test_release_add_get_arbitrary.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1642/ for more details.