core.cli: Fix the create option as flag
ClosedPublic
Actions

Authored by ardumont on Dec 13 2018, 4:24 PM.

Details

Reviewers

douardda
vlorentz

Group Reviewers

Reviewers

Commits

rDCORE386f8e2097c5: core.cli: Use lower case short option and remove useless is_flag
rDCORE0915234baa66: core.cli: Fix the create option as flag and keep original behavior

Summary

Prior to this commit, unexpectedly the option was not a flag:

-C, --no-create TEXT  Do not attempt to create the database

So we would have had to pass along an extra boolean with the option.

Now it's simpler:

-c, --create / --no-create  Attempt to create the database

Test Plan

tox

Diff Detail

Repository

rDCORE Foundations and core functionalities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Dec 13 2018, 4:24 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/99/ for more details.

Harbormaster completed remote builds in B3009: Diff 2583.Dec 13 2018, 4:27 PM

ardumont mentioned this in D814: swh-storage/entrypoint.sh: Fix issue on initialisation step.Dec 13 2018, 4:27 PM

douardda requested changes to this revision.Dec 13 2018, 5:12 PM

douardda added inline comments.

swh/core/cli.py
24–28	if you change the flag default value (thus meaning), use lower case short flag (here -c) Makes no sense to keep it uppercase here. Also the is_flag is not needed since you use the complete long version form for a flag '--create/--no-create'

This revision now requires changes to proceed.Dec 13 2018, 5:12 PM

core.cli: Use lower case short option and remove useless is_flag

ardumont retitled this revision from core.cli: Fix the create option as flag and keep original behavior to core.cli: Fix the create option as flag.Dec 13 2018, 5:16 PM

ardumont edited the summary of this revision. (Show Details)

douardda accepted this revision.Dec 13 2018, 5:16 PM

This revision is now accepted and ready to land.Dec 13 2018, 5:16 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/100/ for more details.

Harbormaster completed remote builds in B3011: Diff 2586.Dec 13 2018, 5:17 PM

Rebase

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/101/ for more details.

Harbormaster completed remote builds in B3012: Diff 2587.Dec 13 2018, 5:19 PM

Closed by commit rDCORE0915234baa66: core.cli: Fix the create option as flag and keep original behavior (authored by ardumont). · Explain WhyDec 13 2018, 5:20 PM

This revision was automatically updated to reflect the committed changes.