Differential D8117

mypy: Turn old type comments into pure type annotations
ClosedPublic
Actions

Authored by anlambert on Jul 12 2022, 3:39 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDWAPPS36f971347d5b: mypy: Turn old type comments into pure type annotations

Summary

Remains of when we were using Python 3.5 in production.

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Jul 12 2022, 3:39 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 12 2022, 3:39 PM

Build has FAILED

Patch application report for D8117 (id=29321)

Rebasing onto b80d078ee1...

Current branch diff-target is up to date.

Changes applied before test

commit 36f971347d5b957dc0da0dcc20a7f4b181bc604c
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Jul 12 15:10:10 2022 +0200

    mypy: Turn old type comments into pure type annotations

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1926/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1926/console

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 12 2022, 4:02 PM

Harbormaster failed remote builds in B30404: Diff 29321!

Build is green

Patch application report for D8117 (id=29321)

Rebasing onto b80d078ee1...

Current branch diff-target is up to date.

Changes applied before test

commit 36f971347d5b957dc0da0dcc20a7f4b181bc604c
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Jul 12 15:10:10 2022 +0200

    mypy: Turn old type comments into pure type annotations

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1927/ for more details.

Harbormaster completed remote builds in B30404: Diff 29321.Jul 12 2022, 4:28 PM

anlambert requested review of this revision.Jul 12 2022, 4:28 PM

vlorentz accepted this revision.Jul 12 2022, 5:13 PM

This revision is now accepted and ready to land.Jul 12 2022, 5:13 PM

Closed by commit rDWAPPS36f971347d5b: mypy: Turn old type comments into pure type annotations (authored by anlambert). · Explain WhyJul 12 2022, 5:22 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS36f971347d5b: mypy: Turn old type comments into pure type annotations.