Page MenuHomeSoftware Heritage

hypothesis_strategies: Add kwargs to composite strategies, to replace default sub-strategies
ClosedPublic

Authored by vlorentz on Jul 11 2022, 6:48 PM.

Details

Summary

This allows callers to pass different (typically, stricter) strategies
to hypothesis instead of filtering the output; which makes example
generation faster.

Diff Detail

Repository
rDMOD Data model
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D8110 (id=29293)

Rebasing onto 0f7a1cbeca...

Current branch diff-target is up to date.
Changes applied before test
commit 251bb38100d949567cdbcc5c9b3bb3fc7f66112f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Jul 11 18:46:42 2022 +0200

    hypothesis_strategies: Add kwargs to composite strategies, to replace default sub-strategies
    
    This allows callers to pass different (typically, stricter) strategies
    to hypothesis instead of filtering the output; which makes example
    generation faster.

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/487/ for more details.

Build is green

Patch application report for D8110 (id=29295)

Rebasing onto 0f7a1cbeca...

Current branch diff-target is up to date.
Changes applied before test
commit d298c584fe8d9c45951ad5ab9051415e4cc0ec70
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Jul 11 18:46:42 2022 +0200

    hypothesis_strategies: Add kwargs to composite strategies, to replace default sub-strategies
    
    This allows callers to pass different (typically, stricter) strategies
    to hypothesis instead of filtering the output; which makes example
    generation faster.

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/488/ for more details.

anlambert added a subscriber: anlambert.

Better like this indeed, looks good to me.

This revision is now accepted and ready to land.Jul 11 2022, 7:02 PM