Differential D8104

loader: Use utf-8 instead of ascii to decode rsync output
ClosedPublic
Actions

Authored by anlambert on Jul 8 2022, 6:33 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLDCVS5a79a325a875: loader: Use utf-8 instead of ascii to decode rsync output

Summary

It exists cases where rsync output will not be ascii decodable so prefer
to use utf-8 instead.

Fixes SWH-LOADER-CVS-18.

Diff Detail

Repository

rDLDCVS CVS Loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Jul 8 2022, 6:33 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 8 2022, 6:33 PM

Build is green

Patch application report for D8104 (id=29260)

Rebasing onto e5215cf198...

Current branch diff-target is up to date.

Changes applied before test

commit 5a79a325a875340816f3695faaf2a0b3e19797ee
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Jul 8 18:29:21 2022 +0200

    loader: Use utf-8 instead of ascii to decode rsync output
    
    It exists cases where rsync output will not be ascii decodable so prefer
    to use utf-8 instead.

See https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/123/ for more details.

Harbormaster completed remote builds in B30346: Diff 29260.Jul 8 2022, 6:35 PM

anlambert requested review of this revision.Jul 8 2022, 6:35 PM

ardumont accepted this revision.Jul 11 2022, 1:53 PM

This revision is now accepted and ready to land.Jul 11 2022, 1:53 PM

Closed by commit rDLDCVS5a79a325a875: loader: Use utf-8 instead of ascii to decode rsync output (authored by anlambert). · Explain WhyJul 11 2022, 3:22 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDLDCVS5a79a325a875: loader: Use utf-8 instead of ascii to decode rsync output.