Page MenuHomeSoftware Heritage

Remove ID-based filters
ClosedPublic

Authored by vlorentz on Jul 4 2022, 2:57 PM.

Diff Detail

Repository
rDOBJS Object storage
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 30237
Build 47264: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 47263: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D8074 (id=29145)

Rebasing onto 667cb87b93...

Current branch diff-target is up to date.
Changes applied before test
commit de6be10bf10d021a08e6da0aaca4aa2fd1483068
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Jul 4 14:57:30 2022 +0200

    Remove ID-based filters
    
    They are not used anywhere

See https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/170/ for more details.

ok, one question inline.

Please rework the commit message to mention directly it's unused: "Remove unused ID-based filters."
That's short enough and to the point, no need for the description then.

swh/objstorage/tests/test_readonly_filter.py
22

why not use pytest like the rest of swh modules?

This revision is now accepted and ready to land.Jul 4 2022, 5:31 PM

Please rework the commit message to mention directly it's unused: "Remove unused ID-based filters."
That's short enough and to the point, no need for the description then.

it implies there are ID-based filters that were not removed

swh/objstorage/tests/test_readonly_filter.py
22

I only moved the file, these are not new tests.

This revision was automatically updated to reflect the committed changes.