Page MenuHomeSoftware Heritage

Add an aiohttp logger class filtering successful requests from a set of fixed ips
AcceptedPublic

Authored by olasd on Jun 22 2022, 3:25 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Summary

This should allow us to cut down on the access log spam coming from swh.provenance.

Test Plan

completely untested for now...

Diff Detail

Repository
rDCORE Foundations and core functionalities
Branch
aiohttp-log-filter
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 30876
Build 48284: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 48283: arc lint + arc unit

Event Timeline

Build has FAILED

Patch application report for D8019 (id=28889)

Rebasing onto 87e7afab11...

Current branch diff-target is up to date.
Changes applied before test
commit c7268c0d1738147b922557e783a4a0aa2b4459ff
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Wed Jun 22 15:21:36 2022 +0200

    Add an aiohttp logger class filtering successful requests from a set of fixed ips
    
    This should allow us to cut down on the access log spam coming from swh.provenance.

Link to build: https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/453/
See console output for more information: https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/453/console

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 22 2022, 3:27 PM
Harbormaster failed remote builds in B29977: Diff 28889!

Build is green

Patch application report for D8019 (id=29824)

Rebasing onto a0e61ab869...

First, rewinding head to replay your work on top of it...
Applying: Add an aiohttp logger class filtering successful requests from a set of fixed ips
Changes applied before test
commit ed0a521643d5afc4f9fade3e9ee43d391ed39262
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Wed Jun 22 15:21:36 2022 +0200

    Add an aiohttp logger class filtering successful requests from a set of fixed ips
    
    This should allow us to cut down on the access log spam coming from swh.provenance.

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/469/ for more details.

Build is green

Patch application report for D8019 (id=29825)

Rebasing onto a0e61ab869...

Current branch diff-target is up to date.
Changes applied before test
commit 397b056cf17c4584273e3570d5584337b3dd128b
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Wed Jun 22 15:21:36 2022 +0200

    Add an aiohttp logger class filtering successful requests from a set of fixed ips
    
    This should allow us to cut down on the access log spam coming from swh.provenance.

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/470/ for more details.

olasd requested review of this revision.Aug 18 2022, 4:58 PM
This revision is now accepted and ready to land.Aug 19 2022, 10:34 AM