Depends on D7998.
Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Commits
- rDLDBASEd627c2598a0e: crates: Fix incorrect documentation of release format
Diff Detail
Diff Detail
- Repository
- rDLDBASE Generic VCS/Package Loader
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 29905 Build 46748: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 46747: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D7999 (id=28819)
Could not rebase; Attempt merge onto d925d06e6f...
Merge made by the 'recursive' strategy. docs/package-loader-specifications.rst | 6 +++--- swh/loader/package/crates/loader.py | 2 +- swh/loader/package/crates/tests/test_crates.py | 26 +++++++++++++------------- 3 files changed, 17 insertions(+), 17 deletions(-)
Changes applied before test
commit 920987f08992eddb31c92992fe970fb2c7934187
Merge: d925d06 de29163
Author: Jenkins user <jenkins@localhost>
Date: Thu Jun 16 12:04:55 2022 +0000
Merge branch 'diff-target' into HEAD
commit de29163511759fb2126d775ade10acea914f1422
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Thu Jun 16 14:04:20 2022 +0200
crates: Fix incorrect documentation of release format
commit ab167227951024dea5f946be2878217a758b02d8
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Thu Jun 16 14:03:55 2022 +0200
crates: Add missing newline in release message
They should use the same convention as Git.See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/803/ for more details.
Comment Actions
ok, one question inline though
| docs/package-loader-specifications.rst | ||
|---|---|---|
| 48 | why the shorter names? | |
Comment Actions
(i thought that was just aligning existing implementation, i noticed only now the depends on the other diff ¯\_(ツ)_/¯)
Comment Actions
Build is green
Patch application report for D7999 (id=28869)
Could not rebase; Attempt merge onto b6af2638c1...
Updating b6af263..d627c25 Fast-forward docs/package-loader-specifications.rst | 6 +++--- swh/loader/package/crates/loader.py | 2 +- swh/loader/package/crates/tests/test_crates.py | 26 +++++++++++++------------- 3 files changed, 17 insertions(+), 17 deletions(-)
Changes applied before test
commit d627c2598a0e326b6c66bd285bd3bee8cb7d1d55
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Thu Jun 16 14:04:20 2022 +0200
crates: Fix incorrect documentation of release format
commit aefc055d961cc52aac9d202bb161dc6b29a70492
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Thu Jun 16 14:03:55 2022 +0200
crates: Add missing newline in release message
They should use the same convention as Git.See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/808/ for more details.