Page MenuHomeSoftware Heritage

crates: Add missing newline in release message
ClosedPublic

Authored by vlorentz on Thu, Jun 16, 2:04 PM.

Details

Summary

They should use the same convention as Git.

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D7998 (id=28818)

Rebasing onto d925d06e6f...

First, rewinding head to replay your work on top of it...
Applying: crates: Add missing newline in release message
Changes applied before test
commit bafa2ed772de74b12f2b5fb918436d8e0079b676
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jun 16 14:03:55 2022 +0200

    crates: Add missing newline in release message
    
    They should use the same convention as Git.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/802/ for more details.

They should use the same convention as Git.

says who? and why?

Also what about the hash changes impact?
Does that imply something regarding deployment?

They should use the same convention as Git.

says who? and why?

Says me, because I don't see any reason to diverge, here.

Also what about the hash changes impact?

It's because the release message changes

Does that imply something regarding deployment?

This loader does not run in production, so none. In staging, it will simply keep the old messages for releases that were already loaded.

This revision is now accepted and ready to land.Tue, Jun 21, 2:20 PM

Build is green

Patch application report for D7998 (id=28868)

Rebasing onto b6af2638c1...

Current branch diff-target is up to date.
Changes applied before test
commit aefc055d961cc52aac9d202bb161dc6b29a70492
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jun 16 14:03:55 2022 +0200

    crates: Add missing newline in release message
    
    They should use the same convention as Git.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/807/ for more details.