Differential D7970

Fix InMemoryJournalWriter: do not anonymize objects by default
ClosedPublic
Actions

Authored by douardda on Jun 8 2022, 12:19 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDJNL6b05a6c949b4: Fix InMemoryJournalWriter: do not anonymize objects by default

Summary

908f0154 introduced and unexpected change of behavior of the
InMemoryJournalWriter, making it always anonymize objects. This broke
tests for some dependencies (swh-storage).

This fix adds an 'anonymize' (bool) argument to the class constructor
(similar to the KafkaJournalWriter).

Diff Detail

Repository

rDJNL Journal infrastructure

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Jun 8 2022, 12:19 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 8 2022, 12:19 PM

(hopefully) a fix for https://jenkins.softwareheritage.org/job/DENV/job/tests/2633/artifact/swh-storage.log

Build is green

Patch application report for D7970 (id=28714)

Rebasing onto a208f882a7...

Current branch diff-target is up to date.

Changes applied before test

commit 1b12d85c4c2ec876b2eb25457518278cef74257a
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Jun 8 12:15:11 2022 +0200

    Fix InMemoryJournalWriter: do not anonymize objects by default
    
    908f0154 introduced and unexpected change of behavior of the
    InMemoryJournalWriter, making it always anonymize objects. This broke
    tests for some dependencies (swh-storage).
    
    This fix adds an 'anonymize' (bool) argument to the class constructor
    (similar to the KafkaJournalWriter).

See https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/219/ for more details.

Harbormaster completed remote builds in B29795: Diff 28714.Jun 8 2022, 12:24 PM

douardda requested review of this revision.Jun 8 2022, 12:24 PM

Looks good, thanks !

This revision is now accepted and ready to land.Jun 8 2022, 12:27 PM

typos in the ci msg

This revision was landed with ongoing or failed builds.Jun 8 2022, 12:30 PM

Closed by commit rDJNL6b05a6c949b4: Fix InMemoryJournalWriter: do not anonymize objects by default (authored by douardda). · Explain Why

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDJNL6b05a6c949b4: Fix InMemoryJournalWriter: do not anonymize objects by default.

Build is green

Patch application report for D7970 (id=28716)

Rebasing onto a208f882a7...

Current branch diff-target is up to date.

Changes applied before test

commit 6b05a6c949b4f278832904965b02ed04bae8dce3
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Jun 8 12:15:11 2022 +0200

    Fix InMemoryJournalWriter: do not anonymize objects by default
    
    908f0154 introduced an unexpected change of behavior of the
    InMemoryJournalWriter, making it always anonymize objects. This broke
    tests for some dependencies (esp. swh-storage).
    
    This fix adds an 'anonymize' (bool) argument to the class constructor
    (similar to the KafkaJournalWriter).

See https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/220/ for more details.

Harbormaster completed remote builds in B29797: Diff 28716.Jun 8 2022, 12:34 PM