Page MenuHomeSoftware Heritage

deprecate the db/pytest_plugin.py module
ClosedPublic

Authored by douardda on Wed, Jun 1, 12:27 PM.

Details

Summary

this diff consist in 4 revisions:

  • tests: use stock pytest_postgresql factory function instead of the custom factory_fact.
  • mark postgresql_fact fixture factory function as deprecated
  • move initialize_database_for_module in db_utils to prepare the deprecation of db/pytest_plugin.py; it's the only function from db/pytest_plugin.py still in use.
  • deprecate the module entirely.

Closes T4285.

Diff Detail

Repository
rDCORE Foundations and core functionalities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build has FAILED

Patch application report for D7934 (id=28586)

Rebasing onto 749ac571a7...

Current branch diff-target is up to date.
Changes applied before test
commit af61ff063c9aeb801cf339c27f9c40cae0b3374b
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Jun 1 12:23:58 2022 +0200

    deprecate the db/pytest_plugin.py module

commit 307ece6fda6fb6b5a3a23dfe85d12ba0fb1db3bd
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Jun 1 12:21:40 2022 +0200

    move initialize_database_for_module in db_utils
    
    to prepare the deprecation of db/pytest_plugin.py; it's the only
    function from db/pytest_plugin.py still in use.

commit b26356329903fb6c7486b979ee7dac14f0b8ed7a
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Jun 1 09:44:41 2022 +0200

    mark postgresql_fact fixture factory function as deprecated

commit 8523bca576b9ff51a7ea5a78173e8af1eee0f041
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Jun 1 09:43:15 2022 +0200

    tests: use stock pytest_postgresql factory function
    
    instead of the custom factory_fact.

Link to build: https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/436/
See console output for more information: https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/436/console

Harbormaster returned this revision to the author for changes because remote builds failed.Wed, Jun 1, 12:29 PM
Harbormaster failed remote builds in B29669: Diff 28586!

fix docstring (=> fix sphinx)

Build is green

Patch application report for D7934 (id=28593)

Rebasing onto 749ac571a7...

Current branch diff-target is up to date.
Changes applied before test
commit 4fc5f601b69a4a9de447e657a085a6154ef4d084
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Jun 1 12:23:58 2022 +0200

    deprecate the db/pytest_plugin.py module

commit ab2ff74346388b7c93e241c4e01a64dc2b76387f
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Jun 1 12:21:40 2022 +0200

    move initialize_database_for_module in db_utils
    
    to prepare the deprecation of db/pytest_plugin.py; it's the only
    function from db/pytest_plugin.py still in use.

commit b26356329903fb6c7486b979ee7dac14f0b8ed7a
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Jun 1 09:44:41 2022 +0200

    mark postgresql_fact fixture factory function as deprecated

commit 8523bca576b9ff51a7ea5a78173e8af1eee0f041
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Jun 1 09:43:15 2022 +0200

    tests: use stock pytest_postgresql factory function
    
    instead of the custom factory_fact.

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/437/ for more details.

This revision is now accepted and ready to land.Wed, Jun 1, 3:43 PM