Maniphest T4285

Deprecate swh.core's postgresql_fact
Closed, MigratedEdits Locked
Actions

Assigned To

gitlab-migration

Authored By

	douardda
	May 31 2022, 4:22 PM

Tags

Subscribers

gitlab-migration

Description

This factory function is not really needed any more. It was mostly used to speed postgresql-based tests (using custom setup/teardown methods doing table truncation instead of full db drop and recreate).

Recent(ish) versions of pytest_postgresql do provide a db creation process speedup using a preconfigured and setup template db to create the database used in each test.

With the work done in f8a07dfa0bf6 (an following revisions), we do not need this custom setup/teardown any more, so it should be deprecated and its usage adapted to stock pytest_postgresql factory function in every dependency still using it.

Revisions and Commits

rDCORE Foundations and core functionalities
	D7934	rDCOREab2ff7434638 move initialize_database_for_module in db_utils
	D7934	rDCORE4fc5f601b69a deprecate the db/pytest_plugin.py module
	D7934	rDCOREb26356329903 mark postgresql_fact fixture factory function as deprecated
	D7934	rDCORE8523bca576b9 tests: use stock pytest_postgresql factory function

Related Objects
Search...

		Status	Assigned	Task
		Migrated	gitlab-migration	T4285 Deprecate swh.core's postgresql_fact
		Migrated	gitlab-migration	T4286 Replace usage of swh.core's postgresql_fact by stock pytest_postgresql's factory function
		Migrated	gitlab-migration	T4287 Replace usage of swh.core's postgresql_fact by stock pytest_postgresql's factory function
		Migrated	gitlab-migration	T4288 Replace usage of swh.core's postgresql_fact by stock pytest_postgresql's factory function
		Migrated	gitlab-migration	T4289 Replace usage of swh.core's postgresql_fact by stock pytest_postgresql's factory function
		Migrated	gitlab-migration	T4290 Replace usage of swh.core's postgresql_fact by stock pytest_postgresql's factory function

Event Timeline

douardda triaged this task as Normal priority.May 31 2022, 4:22 PM

douardda created this task.

douardda closed subtask T4288: Replace usage of swh.core's postgresql_fact by stock pytest_postgresql's factory function as Resolved.May 31 2022, 4:52 PM

douardda closed subtask T4287: Replace usage of swh.core's postgresql_fact by stock pytest_postgresql's factory function as Resolved.May 31 2022, 6:45 PM

douardda closed subtask T4290: Replace usage of swh.core's postgresql_fact by stock pytest_postgresql's factory function as Resolved.

douardda closed subtask T4286: Replace usage of swh.core's postgresql_fact by stock pytest_postgresql's factory function as Resolved.May 31 2022, 7:28 PM

douardda closed subtask T4289: Replace usage of swh.core's postgresql_fact by stock pytest_postgresql's factory function as Resolved.Jun 1 2022, 11:42 AM

douardda added a revision: D7934: deprecate the db/pytest_plugin.py module.Jun 1 2022, 12:27 PM

Actually, with a bit more work, it's the entire db/pytest_plugin.py module that can be deprecated.

douardda added a commit: rDCORE8523bca576b9: tests: use stock pytest_postgresql factory function.Jun 2 2022, 9:52 AM

douardda added a commit: rDCOREb26356329903: mark postgresql_fact fixture factory function as deprecated.

douardda added a commit: rDCORE4fc5f601b69a: deprecate the db/pytest_plugin.py module.

douardda added a commit: rDCOREab2ff7434638: move initialize_database_for_module in db_utils.

douardda closed this task as Resolved.Jun 2 2022, 9:53 AM

douardda claimed this task.

This task has been migrated to GitLab.

gitlab-migration changed the status of subtask T4286: Replace usage of swh.core's postgresql_fact by stock pytest_postgresql's factory function from Resolved to Migrated.Jan 8 2023, 4:37 PM

gitlab-migration changed the status of subtask T4287: Replace usage of swh.core's postgresql_fact by stock pytest_postgresql's factory function from Resolved to Migrated.

gitlab-migration changed the status of subtask T4288: Replace usage of swh.core's postgresql_fact by stock pytest_postgresql's factory function from Resolved to Migrated.

gitlab-migration changed the status of subtask T4289: Replace usage of swh.core's postgresql_fact by stock pytest_postgresql's factory function from Resolved to Migrated.

gitlab-migration changed the status of subtask T4290: Replace usage of swh.core's postgresql_fact by stock pytest_postgresql's factory function from Resolved to Migrated.