Page MenuHomeSoftware Heritage

tests: use stock pytest_postgresql factory function
ClosedPublic

Authored by douardda on May 31 2022, 6:39 PM.

Details

Summary

instead of (soon-to-be-deprecated) swh-core's postgresql_fact one.

Depends on D7929.
Closes T4289.

Diff Detail

Repository
rDVAU Software Heritage Vault
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build has FAILED

Patch application report for D7930 (id=28566)

Could not rebase; Attempt merge onto 922a1ea0aa...

Updating 922a1ea..a14bc31
Fast-forward
 swh/vault/tests/conftest.py     | 29 +++----------
 swh/vault/tests/test_cookers.py | 91 ++++++++++++++++++-----------------------
 2 files changed, 45 insertions(+), 75 deletions(-)
Changes applied before test
commit a14bc3169ca1221a1db9132b0ae35a0bf3d1bbaf
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue May 31 16:55:35 2022 +0200

    tests: use stock pytest_postgresql factory function
    
    instead of (soon-to-be-deprecated) swh-core's postgresql_fact one.

commit 83b4cad7af66c1076fc34a804a158b6c04e3d2d1
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue May 31 18:24:03 2022 +0200

    use an in-memory storage for tests
    
    to reduce test execution time a bit.

Link to build: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/233/
See console output for more information: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/233/console

Harbormaster returned this revision to the author for changes because remote builds failed.May 31 2022, 6:43 PM
Harbormaster failed remote builds in B29651: Diff 28566!

Build is green

Patch application report for D7930 (id=28572)

Could not rebase; Attempt merge onto 922a1ea0aa...

Updating 922a1ea..2f6dedc
Fast-forward
 swh/vault/tests/conftest.py             | 29 ++---------
 swh/vault/tests/test_cookers.py         | 91 +++++++++++++++------------------
 swh/vault/tests/test_git_bare_cooker.py | 22 +++++++-
 3 files changed, 66 insertions(+), 76 deletions(-)
Changes applied before test
commit 2f6dedcd30a308415246e37169c8c453d28d5183
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue May 31 16:55:35 2022 +0200

    tests: use stock pytest_postgresql factory function
    
    instead of (soon-to-be-deprecated) swh-core's postgresql_fact one.

commit b7b7927ec97b61c4943a6b6f1eb17a72ca19dae1
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue May 31 18:24:03 2022 +0200

    use an in-memory storage for test_cookers and test_to_disk
    
    to reduce test execution time a bit.
    Keep test_git_bare_cooker using a postgresql backend, since it depends
    on it (support for displayname).

See https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/235/ for more details.

This revision is now accepted and ready to land.Jun 1 2022, 9:25 AM