Differential D7920

tests: use stock pytest_postgresql factory function
ClosedPublic
Actions

Authored by douardda on May 31 2022, 2:24 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T4287: Replace usage of swh.core's postgresql_fact by stock pytest_postgresql's factory function

Commits

rDSCHef1538503dd3: tests: use stock pytest_postgresql factory function

Summary

instead of (soon-to-be-deprecated) swh-core's postgresql_fact one.

Diff Detail

Repository

rDSCH Scheduling utilities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.May 31 2022, 2:24 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 31 2022, 2:24 PM

Build is green

Patch application report for D7920 (id=28538)

Rebasing onto e56fc4d1ed...

Current branch diff-target is up to date.

Changes applied before test

commit 88d179fe992cf8479f102b43f312c03bcdc4c3c4
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue May 31 14:21:31 2022 +0200

    tests: use stock pytest_postgresql factory function
    
    instead of (soon-to-be-deprecated) swh-core's postgresql_fact one.

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/550/ for more details.

Harbormaster completed remote builds in B29629: Diff 28538.May 31 2022, 2:29 PM

douardda requested review of this revision.May 31 2022, 2:29 PM

lgtm

one remark, I'd be neat you add the related task id on those diffs (if there is one).

Oh also, it might be good to have a loop at the requirements-test.txt to eventually drop swh.core[db] requirements then?

swh/scheduler/pytest_plugin.py
1	copyright header.

This revision is now accepted and ready to land.May 31 2022, 2:37 PM

In D7920#205795, @ardumont wrote:

lgtm

one remark, I'd be neat you add the related task id on those diffs (if there is one).

Ah, sure, would be better...

Oh also, it might be good to have a loop at the requirements-test.txt to eventually drop swh.core[db] requirements then?

Nope, It's still needed.

douardda added a task: T4287: Replace usage of swh.core's postgresql_fact by stock pytest_postgresql's factory function .May 31 2022, 4:42 PM

update copyright

Build is green

Patch application report for D7920 (id=28561)

Rebasing onto e56fc4d1ed...

Current branch diff-target is up to date.

Changes applied before test

commit ef1538503dd304f79f790963eee700a707870b3c
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue May 31 14:21:31 2022 +0200

    tests: use stock pytest_postgresql factory function
    
    instead of (soon-to-be-deprecated) swh-core's postgresql_fact one.

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/551/ for more details.

Harbormaster completed remote builds in B29646: Diff 28561.May 31 2022, 4:52 PM

douardda marked an inline comment as done.May 31 2022, 6:44 PM

Closed by commit rDSCHef1538503dd3: tests: use stock pytest_postgresql factory function (authored by douardda). · Explain WhyMay 31 2022, 6:45 PM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDSCHef1538503dd3: tests: use stock pytest_postgresql factory function.