Differential D7888

Represent filtered_objects_percent as a histogram rather than average
ClosedPublic
Actions

Authored by vlorentz on May 24 2022, 3:49 PM.

Details

Reviewers

douardda

Group Reviewers

Reviewers

Commits

rDLDG44e35e4e242b: Represent filtered_objects_percent as a histogram rather than average

Summary

It does not really make sense to average percentages, because they are unweighted,
and do not tell anything more than totals about individual runs.

Diff Detail

Repository

rDLDG Git loader

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 29555
Build 46182: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 46181: arc lint + arc unit

Event Timeline

vlorentz created this revision.May 24 2022, 3:49 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 24 2022, 3:49 PM

Build is green

Patch application report for D7888 (id=28465)

Rebasing onto 356b554285...

Current branch diff-target is up to date.

Changes applied before test

commit 44e35e4e242bcd8d64740dc29e44aad1486aa9d7
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue May 24 15:49:41 2022 +0200

    Represent filtered_objects_percent as a histogram rather than average
    
    It does not really make sense to average percentages, because they are unweighted,
    and do not tell anything more than totals about individual runs.

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/223/ for more details.

Harbormaster completed remote builds in B29555: Diff 28465.May 24 2022, 3:53 PM

vlorentz requested review of this revision.May 24 2022, 3:53 PM

douardda accepted this revision.May 25 2022, 1:53 PM

This revision is now accepted and ready to land.May 25 2022, 1:53 PM

Please do test this in docker or something to check it does what you want to avoid yet another ping pong with staging/production deployment.

Closed by commit rDLDG44e35e4e242b: Represent filtered_objects_percent as a histogram rather than average (authored by vlorentz). · Explain WhyMay 25 2022, 2:03 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDLDG44e35e4e242b: Represent filtered_objects_percent as a histogram rather than average.