Page MenuHomeSoftware Heritage

assets/admin/deposits: Remove deposits filtering by user for non staff
ClosedPublic

Authored by anlambert on Thu, May 12, 5:41 PM.

Details

Summary

The deposits admin view is read only and there is no sensitive data
displayed here so we can remove the deposits filtering by username
for non staff users but with adequate permission.

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D7825 (id=28255)

Rebasing onto c328c4890c...

Current branch diff-target is up to date.
Changes applied before test
commit 6f392c925133910b1be1d496803ee014dc74a121
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu May 12 17:39:02 2022 +0200

    assets/admin/deposits: Remove deposits filtering by user for non staff
    
    The deposits admin view is read only and there is no sensitive data
    displayed here so we can remove the deposits filetering by username
    for non staff users but with adequate permission.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1833/ for more details.

vlorentz added a subscriber: vlorentz.

it's all client-side anyway *shrug*

This revision is now accepted and ready to land.Thu, May 12, 6:05 PM
This revision was landed with ongoing or failed builds.Thu, May 12, 6:12 PM
This revision was automatically updated to reflect the committed changes.

Build is green

Patch application report for D7825 (id=28256)

Rebasing onto c328c4890c...

Current branch diff-target is up to date.
Changes applied before test
commit 3cd8cc76df4bfcc0b807fcffcb2c28959bc91155
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu May 12 17:39:02 2022 +0200

    assets/admin/deposits: Remove deposits filtering by user for non staff
    
    The deposits admin view is read only and there is no sensitive data
    displayed here so we can remove the deposits filtering by username
    for non staff users but with adequate permission.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1835/ for more details.