Differential D7755

origin_search: Allow to pass empty query or URL pattern parameters
ClosedPublic
Actions

Authored by anlambert on May 6 2022, 2:09 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDSEAc847e9bbb0b6: origin_search: Allow to pass empty query or URL pattern parameters

Summary

In that case, the search will match all origins and return them in a
paginated way.

It also enables to consider all origins when filtering them according
to different criterions (visit type for instance).

These small changes will enable to improve the search features available
in swh-web.

Related to D7756

Diff Detail

Repository

rDSEA Archive search

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.May 6 2022, 2:09 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 6 2022, 2:09 PM

anlambert added a child revision: D7756: search: Allow to pass empty pattern when searching for origins.May 6 2022, 2:11 PM

anlambert edited the summary of this revision. (Show Details)May 6 2022, 2:12 PM

Build is green

Patch application report for D7755 (id=28062)

Rebasing onto ca662a57b0...

Current branch diff-target is up to date.

Changes applied before test

commit c847e9bbb0b600a707d070aa61a4cc5aa8bc8b26
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu May 5 14:19:51 2022 +0200

    origin_search: Allow to pass empty query or URL pattern parameters
    
    In that case, the search will match all origins and return them in a
    paginated way.
    
    It also enables to consider all origins when filtering them according
    to different criterions (visit type for instance).
    
    These small changes will enable to improve the search features available
    in swh-web.

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/332/ for more details.

Harbormaster completed remote builds in B29133: Diff 28062.May 6 2022, 2:14 PM

anlambert requested review of this revision.May 6 2022, 2:14 PM

vlorentz accepted this revision.May 6 2022, 2:29 PM

This revision is now accepted and ready to land.May 6 2022, 2:29 PM

Closed by commit rDSEAc847e9bbb0b6: origin_search: Allow to pass empty query or URL pattern parameters (authored by anlambert). · Explain WhyMay 6 2022, 2:45 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDSEAc847e9bbb0b6: origin_search: Allow to pass empty query or URL pattern parameters.