Revert long_description_content_type to 'text/x-rst'
ClosedPublic
Actions

Authored by vlorentz on Apr 26 2022, 2:57 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLDCVS3a99ed0df972: Revert long_description_content_type to 'text/x-rst'

Summary

9474ab230bfdf71cde19aec587cade5dab943ace was a workaround for this role being
unknown to PyPI.

Removing the role fixes the issue. I also do not think it is very useful;
all loaders have this entry point.

Diff Detail

Repository

rDLDCVS CVS Loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Apr 26 2022, 2:57 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 26 2022, 2:57 PM

Build is green

Patch application report for D7685 (id=27777)

Rebasing onto bdd1f7c756...

Current branch diff-target is up to date.

Changes applied before test

commit 53e3df8288e79226de86804df617aabec6953940
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Apr 26 14:57:37 2022 +0200

    Revert long_description_content_type to 'text/x-rst'
    
    9474ab230bfdf71cde19aec587cade5dab943ace was a workaround for this role being
    unknown to PyPI.
    
    Removing the role fixes the issue. I also do not think it is very useful;
    all loaders have this entry point.

See https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/105/ for more details.

Harbormaster completed remote builds in B28836: Diff 27777.Apr 26 2022, 2:59 PM

vlorentz requested review of this revision.Apr 26 2022, 2:59 PM

don't remove the text altogether

Thanks and thanks for the iteration, i found it better to keep the entry point for potential contributors.

This revision is now accepted and ready to land.Apr 26 2022, 3:04 PM

anlambert added a subscriber: anlambert.Apr 26 2022, 3:05 PM

anlambert added inline comments.

docs/README.rst
9	Why removing the link to the class autodoc ?

Build is green

Patch application report for D7685 (id=27779)

Rebasing onto bdd1f7c756...

Current branch diff-target is up to date.

Changes applied before test

commit 3a99ed0df97281ad2e4555d56ecbacb7c575573e
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Apr 26 14:57:37 2022 +0200

    Revert long_description_content_type to 'text/x-rst'
    
    9474ab230bfdf71cde19aec587cade5dab943ace was a workaround for this role being
    unknown to PyPI.
    
    Removing the role fixes the issue. I also do not think it is very useful;
    all loaders have this entry point.

See https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/106/ for more details.

Harbormaster completed remote builds in B28838: Diff 27779.Apr 26 2022, 3:05 PM

ardumont added inline comments.Apr 26 2022, 3:06 PM