Page MenuHomeSoftware Heritage
Differential D764

Add yarn to the base docker image
ClosedPublic
Actions

Authored by olasd on Dec 3 2018, 10:54 PM.

Details

Reviewers
douardda
anlambert
Commits
rCDFJ42922f8f9fbe: Add yarn to the base docker image
Summary

Needed to build assets for swh-web

Test Plan

make all

Diff Detail

Repository
rCDFJ Dockerfiles for Jenkins
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Dec 3 2018, 10:54 PM
Harbormaster completed remote builds in B2800: Diff 2402.Dec 3 2018, 10:54 PM
olasd added a child revision: D765: Add yarn build to PyPI upload targets.Dec 3 2018, 10:58 PM
anlambert added a subscriber: anlambert.Dec 4 2018, 10:53 AM
anlambert added inline comments.
base/Dockerfile
24

webpack requires node > 4.x and nodejs-legacy has version 4.8.2~dfsg-1 in debian stretch.

The nodejs package from stretch-backports should be used instead here.

olasd updated this revision to Diff 2404.Dec 4 2018, 11:27 AM

Use nodejs from stretch-backports

Harbormaster completed remote builds in B2802: Diff 2404.Dec 4 2018, 11:27 AM
olasd marked an inline comment as done.Dec 4 2018, 11:28 AM

Thanks for the heads-up, fixed!

anlambert accepted this revision.Dec 4 2018, 11:28 AM
This revision is now accepted and ready to land.Dec 4 2018, 11:28 AM
Closed by commit rCDFJ42922f8f9fbe: Add yarn to the base docker image (authored by olasd). · Explain WhyDec 4 2018, 11:29 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
base/
42 lines

Diff 2405

View Options

base/Dockerfile

Loading...
About · Developer information · Legal