Differential D7649

maven: Remove duplicated code related to setting instance from netloc
ClosedPublic
Actions

Authored by anlambert on Apr 25 2022, 4:48 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLS334c54091e85: maven: Remove duplicated code related to setting instance from netloc

Summary

That processing is already handled in the base Lister class constructor.

Diff Detail

Repository

rDLS Listers

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Apr 25 2022, 4:48 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 25 2022, 4:48 PM

Build is green

Patch application report for D7649 (id=27674)

Rebasing onto 2fa9f0abd2...

Current branch diff-target is up to date.

Changes applied before test

commit 8d7f3637fc7fa052ec086c0597c35ac268684cc1
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Apr 25 16:45:15 2022 +0200

    maven: Remove duplicated code related to setting instance from netloc
    
    That processing is already handled in the base Lister class constructor.

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/499/ for more details.

Harbormaster completed remote builds in B28731: Diff 27674.Apr 25 2022, 4:52 PM

anlambert requested review of this revision.Apr 25 2022, 4:52 PM

ardumont accepted this revision.Apr 25 2022, 5:01 PM

This revision is now accepted and ready to land.Apr 25 2022, 5:01 PM

Rebase

Build is green

Patch application report for D7649 (id=27677)

Rebasing onto d0924f39d0...

Current branch diff-target is up to date.

Changes applied before test

commit 334c54091e853af7e2857462cd84725787f396c0
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Apr 25 16:45:15 2022 +0200

    maven: Remove duplicated code related to setting instance from netloc
    
    That processing is already handled in the base Lister class constructor.

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/500/ for more details.

Harbormaster completed remote builds in B28736: Diff 27677.Apr 25 2022, 5:37 PM

Closed by commit rDLS334c54091e85: maven: Remove duplicated code related to setting instance from netloc (authored by anlambert). · Explain WhyApr 26 2022, 10:58 AM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDLS334c54091e85: maven: Remove duplicated code related to setting instance from netloc.