Page MenuHomeSoftware Heritage

Add new supported visit type 'maven'
ClosedPublic

Authored by ardumont on Apr 22 2022, 2:58 PM.

Details

Summary

Without this, the following query fails in the archive [1].

While without specifying anything [2], it works.

The following commit should fix the issue with the [1] link.

[1] https://webapp.staging.swh.network/browse/search/?q=repo1.maven.org&with_visit=true&with_content=true&visit_type=maven

[2] https://webapp.staging.swh.network/browse/search/?q=repo1.maven.org&with_visit=true&with_content=true

Thanks to @anlambert for pointing it out.

Test Plan

Related to T4192

Diff Detail

Repository
rDSEA Archive search
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 28688
Build 44827: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 44826: arc lint + arc unit

Event Timeline

Build was aborted

Patch application report for D7631 (id=27636)

Rebasing onto 418a660b8a...

Current branch diff-target is up to date.
Changes applied before test
commit f525e2534d1a7ea1a48143c6949c2731c90c3781
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Apr 22 14:52:18 2022 +0200

    Add new supported visit type 'maven'
    
    Without this, the following query fails in the archive [1].
    
    While without specifying anything [2], it works.
    
    The following commit should fix the issue with the [1] link.
    
    [1] https://webapp.staging.swh.network/browse/search/?q=repo1.maven.org&with_visit=true&with_content=true&visit_type=maven
    
    [2] https://webapp.staging.swh.network/browse/search/?q=repo1.maven.org&with_visit=true&with_content=true

Link to build: https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/327/
See console output for more information: https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/327/console

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 22 2022, 3:10 PM
Harbormaster failed remote builds in B28688: Diff 27636!

Rebase on top of green master

Build is green

Patch application report for D7631 (id=27664)

Rebasing onto 377ba2c8c1...

Current branch diff-target is up to date.
Changes applied before test
commit 88a04c542f4c71aec51dd13e590aa84cb8d24289
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Apr 22 14:52:18 2022 +0200

    Add new supported visit type 'maven'
    
    Without this, the following query fails in the archive [1].
    
    While without specifying anything [2], it works.
    
    The following commit should fix the issue with the [1] link.
    
    [1] https://webapp.staging.swh.network/browse/search/?q=repo1.maven.org&with_visit=true&with_content=true&visit_type=maven
    
    [2] https://webapp.staging.swh.network/browse/search/?q=repo1.maven.org&with_visit=true&with_content=true

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/330/ for more details.

This revision is now accepted and ready to land.Apr 25 2022, 2:36 PM
This revision was automatically updated to reflect the committed changes.