Differential D7575

backends: Report only relevant exceptions to sentry
ClosedPublic
Actions

Authored by anlambert on Apr 14 2022, 11:14 AM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDAUTH7fddad7eb2b8: backends: Report only relevant exceptions to sentry

Summary

When catching KeycloakError exceptions, other exception types
will be then raised like ValueError or AuthenticationFailed.

Those will be processed by django applications using these auth
middlewares so there is no need to duplicate error reports in
sentry here.

Diff Detail

Repository

rDAUTH Common authentication libraries

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Apr 14 2022, 11:14 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 14 2022, 11:14 AM

Build is green

Patch application report for D7575 (id=27442)

Rebasing onto 882f35e490...

Current branch diff-target is up to date.

Changes applied before test

commit 7fddad7eb2b8d3eb797b38cc277e6d11a5679fee
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Apr 14 11:06:06 2022 +0200

    backends: Report only relevant exceptions to sentry
    
    When catching KeycloakError exceptions, other exception types
    will be then raised like ValueError or AuthenticationFailed.
    
    Those will be processed by django applications using these auth
    middlewares so there is no need to duplicate error reports in
    sentry here.

See https://jenkins.softwareheritage.org/job/DAUTH/job/tests-on-diff/87/ for more details.

Harbormaster completed remote builds in B28457: Diff 27442.Apr 14 2022, 11:16 AM

anlambert requested review of this revision.Apr 14 2022, 11:16 AM

vlorentz accepted this revision.Apr 14 2022, 12:10 PM

This revision is now accepted and ready to land.Apr 14 2022, 12:10 PM

Closed by commit rDAUTH7fddad7eb2b8: backends: Report only relevant exceptions to sentry (authored by anlambert). · Explain WhyApr 14 2022, 1:17 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDAUTH7fddad7eb2b8: backends: Report only relevant exceptions to sentry.