Differential D7573

maven: Consistently read lister input to ingest a mvn origin
ClosedPublic
Actions

Authored by ardumont on Apr 14 2022, 9:53 AM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T3874: staging: Analyze result of the maven listing and ingestion

Commits

rDLDBASE94fe47838f54: maven: Consistently read lister input to ingest a mvn origin

Summary

Prior to this commit, the test data were in the wrong format. They were passing along an
url within the artifact parameter which is not provided by the lister.

This fixes the inconsistency.

Bonus point, by adapting the loader this way, there is no need to tamper with the listed_origins
data table (scheduler).

Related to T3874

Test Plan

tox

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Apr 14 2022, 9:53 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 14 2022, 9:53 AM

ardumont edited the summary of this revision. (Show Details)Apr 14 2022, 9:54 AM

Drop unneeded comment

Build is green

Patch application report for D7573 (id=27433)

Rebasing onto 255f3b2858...

Current branch diff-target is up to date.

Changes applied before test

commit e551efc92e560cd62bde6e49e962d7302e9e625b
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Apr 14 09:51:44 2022 +0200

    maven: Consistently read lister input to ingest a mvn origin
    
    Prior to this commit, the test data were in the wrong format. They were passing along an
    url within the artifact parameter which is not provided by the lister.
    
    This fixes the inconsistency.
    
    Related to T3874

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/715/ for more details.

Harbormaster completed remote builds in B28448: Diff 27433.Apr 14 2022, 9:56 AM

Build is green

Patch application report for D7573 (id=27434)

Rebasing onto 255f3b2858...

Current branch diff-target is up to date.

Changes applied before test

commit 94fe47838f54435efcfb864a1e4e475f6ab28805
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Apr 14 09:51:44 2022 +0200

    maven: Consistently read lister input to ingest a mvn origin
    
    Prior to this commit, the test data were in the wrong format. They were passing along an
    url within the artifact parameter which is not provided by the lister.
    
    This fixes the inconsistency.
    
    Related to T3874

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/716/ for more details.

Harbormaster completed remote builds in B28449: Diff 27434.Apr 14 2022, 9:58 AM

ardumont requested review of this revision.Apr 14 2022, 9:58 AM

ardumont mentioned this in T3874: staging: Analyze result of the maven listing and ingestion.Apr 14 2022, 10:19 AM

vlorentz accepted this revision.Apr 14 2022, 11:39 AM

This revision is now accepted and ready to land.Apr 14 2022, 11:39 AM

Closed by commit rDLDBASE94fe47838f54: maven: Consistently read lister input to ingest a mvn origin (authored by ardumont). · Explain WhyApr 14 2022, 11:40 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDBASE94fe47838f54: maven: Consistently read lister input to ingest a mvn origin.