Differential D7563

sentry: Add parameter 'ignored_exceptions'
AbandonedPublic
Actions

Authored by vlorentz on Apr 13 2022, 2:44 PM.

Details

Reviewers

None

Group Reviewers

Reviewers

Summary

It takes an iterable of exception classes, whose instances should not be
logged to Sentry

w/ @jayeshv @ardumont @vsellier

Diff Detail

Repository

rDCORE Foundations and core functionalities

Branch

sentry

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 28430
Build 44447: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 44446: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	4 ms	Jenkins > .tox.py3-core-db-server-slow-cover.lib.python3.7.site-packages.swh.core.tests.test_cli::test_sentry __wrapped_mock_method__ = <function NonCallableMock.assert_called_with at 0x7f8bacf6f048> args = (<MagicMock name='init' id='140237825300688'>,) kwargs = {'debug': False, 'dsn': 'test_dsn', 'environment': None, 'integrations': [], ...}
	4 ms	Jenkins > .tox.py3-core-db-server-slow-cover.lib.python3.7.site-packages.swh.core.tests.test_cli::test_sentry_debug __wrapped_mock_method__ = <function NonCallableMock.assert_called_with at 0x7f8bacf6f048> args = (<MagicMock name='init' id='140237824895576'>,) kwargs = {'debug': True, 'dsn': 'test_dsn', 'environment': None, 'integrations': [], ...}
	4 ms	Jenkins > .tox.py3-core-db-server-slow-cover.lib.python3.7.site-packages.swh.core.tests.test_cli::test_sentry_env __wrapped_mock_method__ = <function NonCallableMock.assert_called_with at 0x7f8bacf6f048> args = (<MagicMock name='init' id='140237823523080'>,) kwargs = {'debug': True, 'dsn': 'test_dsn', 'environment': None, 'integrations': [], ...}
	6 ms	Jenkins > .tox.py3-core-db-server-slow-cover.lib.python3.7.site-packages.swh.core.tests.test_cli::test_sentry_env_main_package __wrapped_mock_method__ = <function NonCallableMock.assert_called_with at 0x7f8bacf6f048> args = (<MagicMock name='init' id='140237823522632'>,) kwargs = {'debug': False, 'dsn': 'test_dsn', 'environment': 'tests', 'integrations': [], ...}
	1 ms	Jenkins > .tox.py3-core-db-server-slow-cover.lib.python3.7.site-packages.swh.core.api.tests.test_async::test_async_decode_data_empty_cases[None]
		View Full Test Results (4 Failed · 261 Passed · 1 Skipped)

Event Timeline

vlorentz created this revision.Apr 13 2022, 2:44 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 13 2022, 2:44 PM

vlorentz edited the summary of this revision. (Show Details)Apr 13 2022, 2:45 PM

vlorentz added subscribers: jayeshv, vsellier, ardumont.

Build has FAILED

Patch application report for D7563 (id=27413)

Rebasing onto ab170ca98c...

First, rewinding head to replay your work on top of it...
Applying: sentry: Add parameter 'ignored_exceptions'
Using index info to reconstruct a base tree...
M	swh/core/api/tests/test_gunicorn.py
Falling back to patching base and 3-way merge...
Auto-merging swh/core/api/tests/test_gunicorn.py
CONFLICT (content): Merge conflict in swh/core/api/tests/test_gunicorn.py
Patch failed at 0001 sentry: Add parameter 'ignored_exceptions'

Resolve all conflicts manually, mark them as resolved with
"git add/rm <conflicted_files>", then run "git rebase --continue".
You can instead skip this commit: run "git rebase --skip".
To abort and get back to the state before "git rebase", run "git rebase --abort".

Rebase failed (ret=1)!

Could not rebase; Attempt merge onto ab170ca98c...

Already up to date.

Changes applied before test

commit a4083ba3b21a8101a9b299479ecf94e61a499df1
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Apr 13 14:44:22 2022 +0200

    sentry: Add parameter 'ignored_exceptions'
    
    It takes an iterable of exception classes, whose instances should not be
    logged to Sentry

Link to build: https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/386/
See console output for more information: https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/386/console

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 13 2022, 2:45 PM

Harbormaster failed remote builds in B28428: Diff 27413!

rebase

vlorentz published this revision for review.Apr 13 2022, 2:51 PM

Build has FAILED

Patch application report for D7563 (id=27415)

Rebasing onto ab170ca98c...

Current branch diff-target is up to date.

Changes applied before test

commit 15feebc2cc24e1f5f0feb9aaaf5be0902ed45ba6
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Apr 13 14:44:22 2022 +0200

    sentry: Add parameter 'ignored_exceptions'
    
    It takes an iterable of exception classes, whose instances should not be
    logged to Sentry

Link to build: https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/387/
See console output for more information: https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/387/console

Harbormaster failed remote builds in B28430: Diff 27415!Apr 13 2022, 2:52 PM

vlorentz mentioned this in D7565: gunicorn_config: Do not log UniqueViolation and StorageArgumentException to Sentry.Apr 13 2022, 2:53 PM

fix cli tests

Build is green

Patch application report for D7563 (id=27417)

Rebasing onto ab170ca98c...

Current branch diff-target is up to date.

Changes applied before test

commit 862ecbdb4242abaee4b80c333a844857f7958db2
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Apr 13 14:44:22 2022 +0200

    sentry: Add parameter 'ignored_exceptions'
    
    It takes an iterable of exception classes, whose instances should not be
    logged to Sentry

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/388/ for more details.

Harbormaster completed remote builds in B28432: Diff 27417.Apr 13 2022, 2:58 PM

replaced by D7566