Differential D7565

gunicorn_config: Do not log UniqueViolation and StorageArgumentException to Sentry
AbandonedPublic
Actions

Authored by vlorentz on Apr 13 2022, 2:53 PM.

Details

Reviewers

None

Group Reviewers

Reviewers

Summary

UniqueViolation is a lost cause, and the current solution is for clients to retry the request
StorageArgumentException is a client error

therefore, neither should be logged by the swh-storage server to Sentry

Test Plan

Will fail because it depends on swh-core: D7563

Diff Detail

Repository

rDSTO Storage manager

Branch

gunicorn

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 28431
Build 44449: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 44448: arc lint + arc unit

Event Timeline

vlorentz created this revision.Apr 13 2022, 2:53 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 13 2022, 2:53 PM

vlorentz published this revision for review.Apr 13 2022, 2:53 PM

Build has FAILED

Patch application report for D7565 (id=27416)

Rebasing onto 75aa07325d...

Current branch diff-target is up to date.

Changes applied before test

commit 9aaea59849d89455f86d0b89862b06e06e8693b4
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Apr 13 14:52:21 2022 +0200

    gunicorn_config: Do not log UniqueViolation and StorageArgumentException to Sentry
    
    * UniqueViolation is a lost cause, and the current solution is for clients
      to retry the request
    * StorageArgumentException is a client error
    
    therefore, neither should be logged by the swh-storage server to Sentry

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1594/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1594/console

Harbormaster failed remote builds in B28431: Diff 27416!Apr 13 2022, 3:04 PM

will need to be rewritten to use D7566 instead of D7563

Build was aborted

Patch application report for D7565 (id=27416)

Rebasing onto 75aa07325d...

Current branch diff-target is up to date.

Changes applied before test

commit 9aaea59849d89455f86d0b89862b06e06e8693b4
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Apr 13 14:52:21 2022 +0200

    gunicorn_config: Do not log UniqueViolation and StorageArgumentException to Sentry
    
    * UniqueViolation is a lost cause, and the current solution is for clients
      to retry the request
    * StorageArgumentException is a client error
    
    therefore, neither should be logged by the swh-storage server to Sentry

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1595/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1595/console

olasd mentioned this in D7569: statsd: add an error_type tag to @timed error counters.Apr 14 2022, 10:22 AM