Differential D7555

replay: Handle external definition parsing error
ClosedPublic
Actions

Authored by anlambert on Apr 12 2022, 2:35 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLDSVN7e06f33f5cbb: replay: Handle external definition parsing error

Summary

It exist cases where an external definition defined on a path is
malformed resulting in a parsing error from the official subversion
client.

In that case, externals defined on that path will not be processed
when exporting a revision.

(swh) anlambert@carnavalet:/tmp$ svn export https://svn.code.sf.net/p/modelbuilder/code@642 modelbuilder
A    modelbuilder
A    modelbuilder/src
A    modelbuilder/src/trunk
A    modelbuilder/src/trunk/contrib
A    modelbuilder/src/trunk/contrib/symbolic
...
A    modelbuilder/html/images/icon_linux.gif
A    modelbuilder/html/create.bat
A    modelbuilder/html/download.fp
svn: E195005: Error parsing svn:externals property on '/tmp/modelbuilder/src/trunk/contrib': 'symbolic -r1288http://svn.freepascal.org/svn/fpcprojects/contrib/symbolic/'

So align loader behavior with official subversion client.

Fixes SWH-LOADER-SVN-7J

Diff Detail

Repository

rDLDSVN Subversion (SVN) loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Apr 12 2022, 2:35 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 12 2022, 2:35 PM

Build is green

Patch application report for D7555 (id=27392)

Rebasing onto 22231373ac...

Current branch diff-target is up to date.

Changes applied before test

commit 7e06f33f5cbb69e5899921f1bdae76f6c8fb7c47
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Apr 12 14:19:32 2022 +0200

    replay: Handle external definition parsing error
    
    It exist cases where an external definition defined on a path is
    malformed resulting in a parsing error from the official subversion
    client.
    
    In that case, externals defined on that path will not be processed
    when exporting a revision.
    
    So align loader behavior with official subversion client.

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/312/ for more details.

Harbormaster completed remote builds in B28402: Diff 27392.Apr 12 2022, 2:37 PM

anlambert requested review of this revision.Apr 12 2022, 2:37 PM

ardumont accepted this revision.Apr 12 2022, 3:14 PM

This revision is now accepted and ready to land.Apr 12 2022, 3:14 PM

Closed by commit rDLDSVN7e06f33f5cbb: replay: Handle external definition parsing error (authored by anlambert). · Explain WhyApr 12 2022, 3:18 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDLDSVN7e06f33f5cbb: replay: Handle external definition parsing error.