Details
- Reviewers
anlambert - Group Reviewers
Reviewers - Commits
- R65:bffd4f5f47c5: Fix limit handling.
R65:81a4ac0e0bd1: Add api_origin_metadata_search.
R65:2ed36c9070e7: Add api_origin_metadata_search.
R65:59f3a772f9a3: Fix test.
R65:fd6b50da8afd: Fix error handling + add test.
R65:4913fd66a6d1: Fix api_origin_metadata_search.
R65:de1ee11b36d1: Bound the limit to 100.
rDWAPPS2ed36c9070e7: Add api_origin_metadata_search.
rDWAPPSde1ee11b36d1: Bound the limit to 100.
rDWAPPSbffd4f5f47c5: Fix limit handling.
rDWAPPS59f3a772f9a3: Fix test.
rDWAPPSfd6b50da8afd: Fix error handling + add test.
rDWAPPS4913fd66a6d1: Fix api_origin_metadata_search.
rDWAPPS81a4ac0e0bd1: Add api_origin_metadata_search.
Diff Detail
- Repository
- rDWAPPS Web applications
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/33/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/33/console
Help wanted: currently failing, but I don't understand why. The code and tests should behave the same way as for api_origin_search
swh/web/api/views/origin.py | ||
---|---|---|
191 | We should've an hardcoded max for limit: uses can specify a larger value than that, but in that case the hardcoded value would win, restricting the result set size. |
Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/34/ for more details.
swh/web/api/views/origin.py | ||
---|---|---|
218 | You must raise a swh.web.common.exc.BadInputExc here. An exception filter is set by the api_doc decorator that will translate it to a response with |
swh/web/api/views/origin.py | ||
---|---|---|
218 | Fixed, thanks. I also added a test for that, which fails because Django infinite-loops while handling the exception -_- |
swh/web/api/views/origin.py | ||
---|---|---|
218 | infinite-recurses * |
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/35/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/35/console
swh/web/tests/api/views/test_origin.py | ||
---|---|---|
295 | You should not pass the fulltext parameter for that test to succed no ? |
swh/web/tests/api/views/test_origin.py | ||
---|---|---|
295 | indeed, thanks -_- |
Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/36/ for more details.
Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/37/ for more details.