Ensure that tests run with the C.UTF-8 locale
ClosedPublic
Actions

Authored by olasd on Apr 1 2022, 11:23 AM.

Details

Reviewers

douardda
ardumont

Group Reviewers

Reviewers

Commits

rDWAPPSad5add7d36e6: Ensure that tests run with the C.UTF-8 locale
rDWAPPSb7d6c93148e9: Move add_forge_now migration tests with other add_forge_now tests

Summary

Some database tests depend on the text returned by the SQL client, which
is localized. Forcing the C locale ensures the text gets output in
English.

Test Plan

it works on my machine (now)...

Diff Detail

Repository

rDWAPPS Web applications

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 28061
Build 43948: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 43947: arc lint + arc unit

Event Timeline

olasd created this revision.Apr 1 2022, 11:23 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 1 2022, 11:23 AM

douardda published this revision for review.Apr 1 2022, 11:36 AM

douardda accepted this revision.

This revision is now accepted and ready to land.Apr 1 2022, 11:36 AM

Build is green

Patch application report for D7483 (id=27143)

Rebasing onto e28c8b5e78...

Current branch diff-target is up to date.

Changes applied before test

commit ad5add7d36e60813120b5b687946e5b2b3933c4c
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Fri Apr 1 11:21:13 2022 +0200

    Ensure that tests run with the C.UTF-8 locale
    
    Some database tests depend on the text returned by the SQL client, which
    is localized. Forcing the C locale ensures the text gets output in
    English.

commit b7d6c93148e92a1e1c128aba0fd5eb278bbd817b
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Fri Apr 1 11:17:45 2022 +0200

    Move add_forge_now migration tests with other add_forge_now tests

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1644/ for more details.

Harbormaster completed remote builds in B28061: Diff 27143.Apr 1 2022, 11:41 AM

ardumont accepted this revision.Apr 1 2022, 11:58 AM

Closed by commit rDWAPPSb7d6c93148e9: Move add_forge_now migration tests with other add_forge_now tests (authored by olasd). · Explain WhyApr 1 2022, 12:14 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDWAPPSb7d6c93148e9: Move add_forge_now migration tests with other add_forge_now tests.

olasd added a commit: rDWAPPSad5add7d36e6: Ensure that tests run with the C.UTF-8 locale.

ardumont mentioned this in D7489: added hyperlinks to URLs in Browse Requests tab.Apr 4 2022, 1:48 PM