Improve `revision_get_parents` implementation in `ArchiveGraph`
AbandonedPublic
Actions

Authored by douardda on Mar 31 2022, 12:18 PM.

Details

Reviewers

vlorentz
aeviso

Group Reviewers

Reviewers

Summary

When a revision is passed, it now retrieves and caches the complete
history three to minimize the queries to the graph.

Fix get_archive to avoid storage parameter for ArchiveGraph

Diff Detail

Repository

rDPROV Provenance database

Branch

master

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 28046
Build 43924: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 43923: arc lint + arc unit

Event Timeline

aeviso created this revision.Mar 31 2022, 12:18 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 31 2022, 12:18 PM

Build is green

Patch application report for D7477 (id=27129)

Rebasing onto 16723f8be4...

Current branch diff-target is up to date.

Changes applied before test

commit 67d7c5733e9b4648b3fb07918b69107fc6bcd036
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Thu Mar 31 12:16:19 2022 +0200

    Fix `get_archive` to avoid `storage` parameter for `ArchiveGraph`

commit 9f77e41049f268ae388f0a1b77cfa7a0c3b49e32
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Thu Mar 31 11:42:47 2022 +0200

    Improve `revision_get_parents` implementation in `ArchiveGraph`
    
    When a revision is passed, it now retrieves and caches the complete
    history three to minimize the queries to the graph.

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/589/ for more details.

Harbormaster completed remote builds in B28046: Diff 27129.Mar 31 2022, 2:29 PM

aeviso requested review of this revision.Mar 31 2022, 2:29 PM

Build is green

Patch application report for D7477 (id=27129)

Rebasing onto 16723f8be4...

Current branch diff-target is up to date.

Changes applied before test

commit 67d7c5733e9b4648b3fb07918b69107fc6bcd036
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Thu Mar 31 12:16:19 2022 +0200

    Fix `get_archive` to avoid `storage` parameter for `ArchiveGraph`

commit 9f77e41049f268ae388f0a1b77cfa7a0c3b49e32
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Thu Mar 31 11:42:47 2022 +0200

    Improve `revision_get_parents` implementation in `ArchiveGraph`
    
    When a revision is passed, it now retrieves and caches the complete
    history three to minimize the queries to the graph.

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/588/ for more details.

aeviso added a child revision: D7478: Clean up `model` removing old unused logic.Mar 31 2022, 3:25 PM

vlorentz accepted this revision.Apr 5 2022, 3:58 PM

This revision is now accepted and ready to land.Apr 5 2022, 3:58 PM

douardda commandeered this revision.Oct 13 2022, 4:38 PM

douardda abandoned this revision.

douardda added a reviewer: aeviso.