I've only opened the configuration and kept the 20 minutes timeout.
(According to discussion here)
Details
Details
- Reviewers
olasd anlambert - Group Reviewers
System administrators - Commits
- rCJSWHdf5580123ebd: Make timeout declaratively parametric on build
Diff Detail
Diff Detail
- Repository
- rCJSWH Jenkins jobs
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 27888 Build 43667: arc lint + arc unit
Event Timeline
Comment Actions
That will apply to all jobs, which I don't think we want to do.
We need to add a job parameter to be able to set the timeout per project.
I'm happy to do that with you if you want.
Comment Actions
I'm happy to do that with you if you want.
sure, that'd be awesome.
i've tentatively tried something out in this very diff.
Comment Actions
You are still setting a timeout of 30 minutes for all jobs.
Do this instead:
(swh) ✔ ~/swh/swh-jenkins-jobs [master|✚ 4⚑ 2] 13:16 $ git diff diff --git a/jobs/swh-packages.yaml b/jobs/swh-packages.yaml index 6de7432..2b57ed0 100644 --- a/jobs/swh-packages.yaml +++ b/jobs/swh-packages.yaml @@ -299,6 +299,7 @@ pkg: web python_module: swh.web do_cypress: true + timeout: 30 jobs: - "swh-jobs-{name}" diff --git a/jobs/templates/swh-pipeline-diff.yaml b/jobs/templates/swh-pipeline-diff.yaml index 5dab0a0..37f602a 100644 --- a/jobs/templates/swh-pipeline-diff.yaml +++ b/jobs/templates/swh-pipeline-diff.yaml @@ -11,6 +11,7 @@ auth-token: 'ph4br1cat0r' phabricator_diff: true do_cypress: false + timeout: 20 properties: - build-discarder: artifact-num-to-keep: 20 diff --git a/jobs/templates/swh-pipeline.groovy.j2 b/jobs/templates/swh-pipeline.groovy.j2 index ded6013..774621f 100644 --- a/jobs/templates/swh-pipeline.groovy.j2 +++ b/jobs/templates/swh-pipeline.groovy.j2 @@ -87,7 +87,7 @@ pipeline { stage('Tests') { options { - timeout(time: 20, unit: 'MINUTES') + timeout(time: {{ timeout }}, unit: 'MINUTES') } parallel { diff --git a/jobs/templates/swh-pipeline.yaml b/jobs/templates/swh-pipeline.yaml index 48bda35..c8e4d5c 100644 --- a/jobs/templates/swh-pipeline.yaml +++ b/jobs/templates/swh-pipeline.yaml @@ -16,6 +16,7 @@ artifact-num-to-keep: 20 phabricator_diff: false do_cypress: false + timeout: 20 parameters: - git-parameter: name: REVISION