Page MenuHomeSoftware Heritage

indexer: Simplify the init step for the last tests
ClosedPublic

Authored by ardumont on Nov 29 2018, 5:42 PM.

Details

Summary
  • tests: Simplify init step

This is probably either in conflict with D740 or need to be rebased
after it.

fossology_license: Fix docstring

Test Plan

tox

Diff Detail

Repository
rDCIDX Metadata indexer
Branch
arcpatch-D742
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2701
Build 3375: tox-on-jenkinsJenkins
Build 3374: arc lint + arc unit

Event Timeline

vlorentz added inline comments.
swh/indexer/tests/test_origin_metadata.py
160–165

^^

swh/indexer/tests/test_utils.py
362–368 ↗(On Diff #2321)

No, that should raise an error.

This revision now requires changes to proceed.Nov 29 2018, 5:45 PM
ardumont marked 2 inline comments as done.

Remove spurious noise

swh/indexer/tests/test_origin_metadata.py
51

but no! that was a tryout.

swh/indexer/tests/test_utils.py
362–368 ↗(On Diff #2321)

In that case, the tests simply won't work.
the tool_id does not exist.

That's a test initialization issue.
the tool_id somehow is a one from the memory storage. I don't get from where that comes from since it's supposed to be mock storage all around.

All this class should go away as that's not tractable in the current state.
So i'm for this ugly hack in the mean time (which will get trashed pretty soon).

swh/indexer/tests/test_origin_metadata.py
51

?

ardumont added inline comments.
swh/indexer/tests/test_origin_metadata.py
51

revision_metadata_indexer = RevisionMetadataTestIndexer()

which has come back and needs to go.
I'll update the diff again.

swh/indexer/tests/test_origin_metadata.py
51

sorry :/

Get back the diff to its feet

The diff got changed by error and i no longer see the right state
there.

ardumont added inline comments.
swh/indexer/tests/test_origin_metadata.py
51

life happens, don't worry ;)

This revision is now accepted and ready to land.Nov 30 2018, 10:51 AM
This revision was automatically updated to reflect the committed changes.