Page MenuHomeSoftware Heritage

Simplify and unify the date field display format in datatable views
ClosedPublic

Authored by ardumont on Mar 24 2022, 11:08 AM.

Details

Summary

As an implementation detail, this reuses the current date format displayed in other similar views.

As such, this slightly diverges from the initial described need in the task (as
mentioned in my task description change).

Shout out if that's not ok and i'll adapt accordingly changing the other views though
(because consistency is important).

Screenshots:

Related to T4074

Test Plan

tests should stay happy

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D7420 (id=26851)

Rebasing onto 6f0cc70fdd...

Current branch diff-target is up to date.
Changes applied before test
commit 1c529ae4949d59f352976c6b6f2365e48c70e13d
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Mar 24 11:00:37 2022 +0100

    Simplify and unify the date field display format in datatable views
    
    Related to T4074

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1556/ for more details.

Fix date displayed in the request dashhoard as well (added new screenshot)

Rename displayHumanReadableDate to getHumanReadableDate

anlambert added a subscriber: anlambert.
anlambert added inline comments.
assets/src/utils/functions.js
146

I think you can remove the type and row parameters.

This revision is now accepted and ready to land.Mar 24 2022, 11:36 AM

Update the deposit view as well

Drop spurious parameters (it's ok indeed, thanks @anlambert ;)

Build is green

Patch application report for D7420 (id=26852)

Rebasing onto 6f0cc70fdd...

Current branch diff-target is up to date.
Changes applied before test
commit 854598e061bf4ba6843fc2b939386ba4088dae55
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Mar 24 11:00:37 2022 +0100

    Simplify and unify the date field display format in datatable views
    
    Related to T4074

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1557/ for more details.

Build is green

Patch application report for D7420 (id=26853)

Rebasing onto 6f0cc70fdd...

Current branch diff-target is up to date.
Changes applied before test
commit 87a31e527464bbdd715c346dd460ce9cac506e12
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Mar 24 11:00:37 2022 +0100

    Simplify date field display format in datatable views
    
    Implementation wise, this extracts and reuses an already defined function to compute
    such date.
    
    Related to T4074

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1558/ for more details.

Build has FAILED

Patch application report for D7420 (id=26854)

Rebasing onto 6f0cc70fdd...

Current branch diff-target is up to date.
Changes applied before test
commit 74347cb6d163966b48affcdb606ac8d4b328139a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Mar 24 11:00:37 2022 +0100

    Simplify date field display format in datatable views
    
    Implementation wise, this extracts and reuses an already defined function to compute
    such date.
    
    Related to T4074

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1559/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1559/console

Build is green

Patch application report for D7420 (id=26855)

Rebasing onto 6f0cc70fdd...

Current branch diff-target is up to date.
Changes applied before test
commit 3cccd744812f4021d51ca324d42a8e7527bfd16e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Mar 24 11:00:37 2022 +0100

    Simplify date field display format in datatable views
    
    Implementation wise, this extracts and reuses an already defined function to compute
    such date.
    
    Related to T4074

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1560/ for more details.

Build is green

Patch application report for D7420 (id=26860)

Rebasing onto 704061c189...

Current branch diff-target is up to date.
Changes applied before test
commit 59da42614b5477c45f4872fce4befc038775b0af
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Mar 24 11:00:37 2022 +0100

    Simplify date field display format in datatable views
    
    Implementation wise, this extracts and reuses an already defined function to compute
    such date.
    
    Related to T4074

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1561/ for more details.