Page MenuHomeSoftware Heritage
Differential D7420

Simplify and unify the date field display format in datatable views
ClosedPublic
Actions

Authored by ardumont on Mar 24 2022, 11:08 AM.

Details

Reviewers
jayeshv
anlambert
Group Reviewers
Reviewers
Maniphest Tasks
T4074: add forge now - simplify date format display
Commits
rDWAPPS59da42614b54: Simplify date field display format in datatable views
Summary

As an implementation detail, this reuses the current date format displayed in other similar views.

As such, this slightly diverges from the initial described need in the task (as
mentioned in my task description change).

Shout out if that's not ok and i'll adapt accordingly changing the other views though
(because consistency is important).

Screenshots:

Related to T4074

Test Plan

tests should stay happy

Diff Detail

Repository
rDWAPPS Web applications
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 27767
Build 43462: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 43461: arc lint + arc unit

Event Timeline

ardumont created this revision.Mar 24 2022, 11:08 AM
ardumont edited the summary of this revision. (Show Details)Mar 24 2022, 11:13 AM
swh-public-ci added a comment.Mar 24 2022, 11:25 AM

Build is green

Patch application report for D7420 (id=26851)

Rebasing onto 6f0cc70fdd...

Current branch diff-target is up to date.
Changes applied before test
commit 1c529ae4949d59f352976c6b6f2365e48c70e13d
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Mar 24 11:00:37 2022 +0100

    Simplify and unify the date field display format in datatable views
    
    Related to T4074

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1556/ for more details.

Harbormaster completed remote builds in B27766: Diff 26851.Mar 24 2022, 11:25 AM
ardumont requested review of this revision.Mar 24 2022, 11:25 AM
ardumont edited the summary of this revision. (Show Details)Mar 24 2022, 11:27 AM
ardumont updated this revision to Diff 26852.Mar 24 2022, 11:28 AM

Fix date displayed in the request dashhoard as well (added new screenshot)

ardumont updated this revision to Diff 26853.Mar 24 2022, 11:30 AM

Rename displayHumanReadableDate to getHumanReadableDate

anlambert accepted this revision.Mar 24 2022, 11:36 AM
anlambert added a subscriber: anlambert.
anlambert added inline comments.
assets/src/utils/functions.js
146

I think you can remove the type and row parameters.

This revision is now accepted and ready to land.Mar 24 2022, 11:36 AM
ardumont updated this revision to Diff 26854.Mar 24 2022, 11:37 AM

Update the deposit view as well

ardumont updated this revision to Diff 26855.Mar 24 2022, 11:39 AM

Drop spurious parameters (it's ok indeed, thanks @anlambert ;)

ardumont marked an inline comment as done.Mar 24 2022, 11:40 AM
swh-public-ci added a comment.Mar 24 2022, 11:47 AM

Build is green

Patch application report for D7420 (id=26852)

Rebasing onto 6f0cc70fdd...

Current branch diff-target is up to date.
Changes applied before test
commit 854598e061bf4ba6843fc2b939386ba4088dae55
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Mar 24 11:00:37 2022 +0100

    Simplify and unify the date field display format in datatable views
    
    Related to T4074

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1557/ for more details.

Harbormaster completed remote builds in B27767: Diff 26852.Mar 24 2022, 11:47 AM
swh-public-ci added a comment.Mar 24 2022, 11:49 AM

Build is green

Patch application report for D7420 (id=26853)

Rebasing onto 6f0cc70fdd...

Current branch diff-target is up to date.
Changes applied before test
commit 87a31e527464bbdd715c346dd460ce9cac506e12
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Mar 24 11:00:37 2022 +0100

    Simplify date field display format in datatable views
    
    Implementation wise, this extracts and reuses an already defined function to compute
    such date.
    
    Related to T4074

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1558/ for more details.

Harbormaster completed remote builds in B27768: Diff 26853.Mar 24 2022, 11:49 AM
swh-public-ci added a comment.Mar 24 2022, 11:56 AM

Build has FAILED

Patch application report for D7420 (id=26854)

Rebasing onto 6f0cc70fdd...

Current branch diff-target is up to date.
Changes applied before test
commit 74347cb6d163966b48affcdb606ac8d4b328139a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Mar 24 11:00:37 2022 +0100

    Simplify date field display format in datatable views
    
    Implementation wise, this extracts and reuses an already defined function to compute
    such date.
    
    Related to T4074

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1559/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1559/console

Harbormaster failed remote builds in B27769: Diff 26854!Mar 24 2022, 11:56 AM
swh-public-ci added a comment.Mar 24 2022, 11:58 AM

Build is green

Patch application report for D7420 (id=26855)

Rebasing onto 6f0cc70fdd...

Current branch diff-target is up to date.
Changes applied before test
commit 3cccd744812f4021d51ca324d42a8e7527bfd16e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Mar 24 11:00:37 2022 +0100

    Simplify date field display format in datatable views
    
    Implementation wise, this extracts and reuses an already defined function to compute
    such date.
    
    Related to T4074

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1560/ for more details.

Harbormaster completed remote builds in B27770: Diff 26855.Mar 24 2022, 11:58 AM
ardumont updated this revision to Diff 26860.Mar 24 2022, 2:26 PM

Rebase

swh-public-ci added a comment.Mar 24 2022, 2:44 PM

Build is green

Patch application report for D7420 (id=26860)

Rebasing onto 704061c189...

Current branch diff-target is up to date.
Changes applied before test
commit 59da42614b5477c45f4872fce4befc038775b0af
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Mar 24 11:00:37 2022 +0100

    Simplify date field display format in datatable views
    
    Implementation wise, this extracts and reuses an already defined function to compute
    such date.
    
    Related to T4074

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1561/ for more details.

Harbormaster completed remote builds in B27776: Diff 26860.Mar 24 2022, 2:44 PM
Closed by commit rDWAPPS59da42614b54: Simplify date field display format in datatable views (authored by ardumont). · Explain WhyMar 24 2022, 2:46 PM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDWAPPS59da42614b54: Simplify date field display format in datatable views.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
assets/
src/
bundles/
add_forge/
4 lines--
6 lines92%
Loading...
4 lines83%
Loading...
8 lines65%
Loading...
admin/
13 lines76%
Loading...
save/
12 lines88%
Loading...
utils/
8 lines83%
Loading...

Diff 26852

View Options

assets/src/bundles/add_forge/add-request-history-item.ejs

Loading...
View Options

assets/src/bundles/add_forge/create-request.js

Loading...
View Options

assets/src/bundles/add_forge/moderation-dashboard.js

Loading...
View Options

assets/src/bundles/add_forge/request-dashboard.js

Loading...
View Options

assets/src/bundles/admin/origin-save.js

Loading...
View Options

assets/src/bundles/save/index.js

Loading...
View Options

assets/src/utils/functions.js

Loading...
About · Developer information · Legal