Page MenuHomeSoftware Heritage

assets/save: Fix Web UI tabs switch when navigating in browser history
ClosedPublic

Authored by anlambert on Mar 16 2022, 5:29 PM.

Details

Summary

In the Save Code Now Web UI, the two displayed tabs have different URLs
but it was not possible to navigate back and forth between them when
clicking on the "Go back" and "Go forward" browser buttons.

So ensure the correct tab will be active when URL fragment has changed.

Diff Detail

Repository
rDWAPPS Web applications
Branch
save-code-now-tab-switch-history
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 27503
Build 43036: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 43035: arc lint + arc unit

Event Timeline

Build has FAILED

Patch application report for D7364 (id=26620)

Rebasing onto 9f2e1cb90c...

Current branch diff-target is up to date.
Changes applied before test
commit 39bab96e9f0484e04fe837b5162d889b8040980a
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Mar 16 17:24:35 2022 +0100

    assets/save: Fix Web UI tabs switch when navigating in browser history
    
    In the Save Code Now Web UI, the two displayed tabs have different URLs
    but it was not possible to navigate back and forth between them when
    clicking on the "Go back" and "Go forward" browser buttons.
    
    So ensure the correct tab will be active when URL fragment has changed.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1474/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1474/console

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 16 2022, 5:31 PM
Harbormaster failed remote builds in B27503: Diff 26620!

Build is green

Patch application report for D7364 (id=26620)

Rebasing onto 9f2e1cb90c...

Current branch diff-target is up to date.
Changes applied before test
commit 39bab96e9f0484e04fe837b5162d889b8040980a
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Mar 16 17:24:35 2022 +0100

    assets/save: Fix Web UI tabs switch when navigating in browser history
    
    In the Save Code Now Web UI, the two displayed tabs have different URLs
    but it was not possible to navigate back and forth between them when
    clicking on the "Go back" and "Go forward" browser buttons.
    
    So ensure the correct tab will be active when URL fragment has changed.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1475/ for more details.

This revision is now accepted and ready to land.Mar 16 2022, 5:51 PM