Differential D7313

svn: Handle sub-project root directory removal in revision
ClosedPublic
Actions

Authored by anlambert on Mar 8 2022, 4:46 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLDSVNaf821525c5cd: svn: Handle sub-project root directory removal in revision

Summary

It exist cases where the root directory of a subversion sub-project
is removed in a revision.

Handle that edge case by returning the empty directory as new root
directory to avoid loading error.

Fixes SWH-LOADER-SVN-6V

Diff Detail

Repository

rDLDSVN Subversion (SVN) loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Mar 8 2022, 4:46 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 8 2022, 4:46 PM

Fix typo in comment

Build is green

Patch application report for D7313 (id=26456)

Rebasing onto eecddf13d5...

Current branch diff-target is up to date.

Changes applied before test

commit 1ab379d0e712535ffb440b65ea25b610eb37f2ea
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Mar 8 16:43:45 2022 +0100

    svn: Handle sub-project root directory removal in revision
    
    It exist cases where the root directory of a subversion sub-project
    is removed in a revision.
    
    Handle that edge case by returning the empty directory as new root
    directory to avoid loading error.

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/306/ for more details.

Harbormaster completed remote builds in B27341: Diff 26456.Mar 8 2022, 4:49 PM

Build is green

Patch application report for D7313 (id=26457)

Rebasing onto eecddf13d5...

Current branch diff-target is up to date.

Changes applied before test

commit af821525c5cd0415daf9dfa8fb5a096b0f3171f1
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Mar 8 16:43:45 2022 +0100

    svn: Handle sub-project root directory removal in revision
    
    It exist cases where the root directory of a subversion sub-project
    is removed in a revision.
    
    Handle that edge case by returning the empty directory as new root
    directory to avoid loading error.

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/307/ for more details.

Harbormaster completed remote builds in B27342: Diff 26457.Mar 8 2022, 4:51 PM

anlambert requested review of this revision.Mar 8 2022, 4:51 PM

ardumont accepted this revision.Mar 8 2022, 6:15 PM

This revision is now accepted and ready to land.Mar 8 2022, 6:15 PM

Closed by commit rDLDSVNaf821525c5cd: svn: Handle sub-project root directory removal in revision (authored by anlambert). · Explain WhyMar 9 2022, 1:57 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDLDSVNaf821525c5cd: svn: Handle sub-project root directory removal in revision.