Properly split optional per-backend requirements
ClosedPublic
Actions

Authored by olasd on Mar 3 2022, 1:26 PM.

Details

Reviewers

Commits

rDOBJS686b70d868e4: Properly split optional per-backend requirements

Summary

For now this is only used to reduce the dependencies generated by the
debian packaging, but we could use that to better isolate per-backend
tests too.

Test Plan

shouldn't affect testing

Diff Detail

Repository

rDOBJS Object storage

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 27248
Build 42622: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 42621: arc lint + arc unit

Event Timeline

olasd created this revision.Mar 3 2022, 1:26 PM

Build is green

Patch application report for D7280 (id=26365)

Rebasing onto 16bb0433c7...

Current branch diff-target is up to date.

Changes applied before test

commit 0a2e0c38b01d25409b9bd7a9bca2a99018f3290d
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Thu Mar 3 13:25:37 2022 +0100

    Properly split optional per-backend requirements
    
    For now this is only used to reduce the dependencies generated by the
    debian packaging, but we could use that to better isolate per-backend
    tests too.

See https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/138/ for more details.

Harbormaster completed remote builds in B27248: Diff 26365.Mar 3 2022, 1:28 PM

olasd requested review of this revision.Mar 3 2022, 1:28 PM

vlorentz added inline comments.Mar 3 2022, 1:46 PM

setup.py
51–56	Shouldn't it declare extras like this, to make it easier to install with a specific backend?

olasd added inline comments.Mar 3 2022, 1:49 PM

setup.py
51–56	Yeah, you're right (even though that's really not a regression compared to the current state, well, except for winery).

add more extras_require possibilities

olasd marked an inline comment as done.Mar 3 2022, 1:50 PM

Build is green

Patch application report for D7280 (id=26369)

Rebasing onto 16bb0433c7...

Current branch diff-target is up to date.

Changes applied before test

commit 686b70d868e4e032b4c0d79887a390d9349d5253
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Thu Mar 3 13:25:37 2022 +0100

    Properly split optional per-backend requirements
    
    For now this is only used to reduce the dependencies generated by the
    debian packaging, but we could use that to better isolate per-backend
    tests too.

See https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/139/ for more details.

Harbormaster completed remote builds in B27252: Diff 26369.Mar 3 2022, 1:53 PM

vlorentz accepted this revision.Mar 3 2022, 1:53 PM

This revision is now accepted and ready to land.Mar 3 2022, 1:53 PM

Closed by commit rDOBJS686b70d868e4: Properly split optional per-backend requirements (authored by olasd). · Explain WhyMar 3 2022, 1:53 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDOBJS686b70d868e4: Properly split optional per-backend requirements.