Move check_url_match_provider to api.checks instead of utils
ClosedPublic
Actions

Authored by olasd on Feb 28 2022, 6:45 PM.

Details

Reviewers

Commits

rDDEPdc1ea97a1ca4: Move check_url_match_provider to api.checks instead of utils

Summary

This function is only used by server-side API checks. Having it defined
in the main utils module makes the deposit client transitively depend on
Django (via swh.deposit.errors), which does not seem necessary.

This undeclared dependency happens to make the swh.icinga_plugins tests red.

Diff Detail

Repository

rDDEP Push deposit

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Feb 28 2022, 6:45 PM

olasd mentioned this in D7264: vault: add monitoring of bundle downloads.Feb 28 2022, 6:46 PM

vlorentz published this revision for review.Feb 28 2022, 6:50 PM

vlorentz accepted this revision.

This revision is now accepted and ready to land.Feb 28 2022, 6:50 PM

Build is green

Patch application report for D7265 (id=26323)

Rebasing onto 841233902d...

Current branch diff-target is up to date.

Changes applied before test

commit dc1ea97a1ca4c657d7755e61d0810106884f9494
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Mon Feb 28 18:35:22 2022 +0100

    Move check_url_match_provider to api.checks instead of utils
    
    This function is only used by server-side API checks. Having it defined
    in the main utils module makes the deposit client transitively depend on
    Django (via swh.deposit.errors), which does not seem necessary.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/792/ for more details.

Harbormaster completed remote builds in B27196: Diff 26323.Feb 28 2022, 6:51 PM

Closed by commit rDDEPdc1ea97a1ca4: Move check_url_match_provider to api.checks instead of utils (authored by olasd). · Explain WhyFeb 28 2022, 7:05 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDDEPdc1ea97a1ca4: Move check_url_match_provider to api.checks instead of utils.